-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: [indicator] adding a bunch of new v2 indicators #1366
base: main
Are you sure you want to change the base?
Conversation
Hi @go-dockly, This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development. This pull request may get 4869 BBG. To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:
Once this pull request is merged, your BBG tokens will be transferred to your wallet. -- Best, |
Re-estimated karma: this pull request may get 9820 BBG |
Re-estimated karma: this pull request may get 9931 BBG |
Re-estimated karma: this pull request may get 10340 BBG |
Re-estimated karma: this pull request may get 10633 BBG |
Re-estimated karma: this pull request may get 11162 BBG |
this PR is getting too big to merge, would you mind to split them and maybe we can merge some changes, like the csv source package, and the kline csv readers, or maybe the extended slice methods. |
Re-estimated karma: this pull request may get 11026 BBG |
Re-estimated karma: this pull request may get 11031 BBG |
Re-estimated karma: this pull request may get 11650 BBG |
There are too many files, like 140+ files that I could not review all files in one round, will continue the review later. Since you're the first-time contributor, it would be nice if you can submit a pull request with a small change, so that the CI could be executed for your later PRs. |
Or, maybe you can pull out the csvsource changes to one PR, I've reviewed these csvsource file changes. |
Re-estimated karma: this pull request may get 8952 BBG |
Re-estimated karma: this pull request may get 8224 BBG |
Re-estimated karma: this pull request may get 8229 BBG |
This build is failing due to the go.mod specified compiler v1.18. |
let’s go with go 1.20
go-dockly ***@***.***>於 2023年11月3日 週五,22:54寫道:
… This build is failing due to the go.mod specified compiler v1.18.
Can we bump to latest go please?
—
Reply to this email directly, view it on GitHub
<#1366 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMNTSVHFERSR2Y7HOMUELYCUAQVAVCNFSM6AAAAAA6QL6GRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGU4DSMJXGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Re-estimated karma: this pull request may get 8364 BBG |
…nto feat/indicators
Re-estimated karma: this pull request may get 8369 BBG |
Re-estimated karma: this pull request may get 8379 BBG |
Re-estimated karma: this pull request may get 8399 BBG |
I think this PR is good to merge now |
@go-dockly could you please rebase the commits? make it no merge-commits in your PR, thanks |
|
No description provided.