REFACTOR: Make fixedmaker simpler #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
narumiruna
commented
Sep 28, 2023
narumiruna
commented
- remove skew and atr multiplier from fixedmaker
- fix common.Strategy.IsHalted
- rename some variables
|
Welcome back! @narumiruna, This pull request may get 286 BBG. |
Codecov Report
@@ Coverage Diff @@
## main #1330 +/- ##
=======================================
Coverage 20.85% 20.85%
=======================================
Files 557 557
Lines 39655 39655
=======================================
Hits 8269 8269
Misses 30786 30786
Partials 600 600 Continue to review full report in Codecov by Sentry.
|
narumiruna
force-pushed
the
narumi/fixedmaker/remove-atr
branch
from
c4ff2e2 to
e34480a
Compare
|
Re-estimated karma: this pull request may get 296 BBG |
narumiruna
force-pushed
the
narumi/fixedmaker/remove-atr
branch
from
e34480a to
c5cd6bc
Compare
|
Re-estimated karma: this pull request may get 301 BBG |
c9s
approved these changes
Oct 3, 2023
gx578007
approved these changes
Oct 4, 2023
|
Hi @narumiruna, Well done! 306 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0xd9db57df98c9c8a2f228f62c10766d394ceac73d386f40acff20f7dfac81c9c3 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.