Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: FEATURE: implement stats tracker #1296

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

c9s
Copy link
Owner

@c9s c9s commented Aug 31, 2023

  • rename Add() to AddProfit() or AddTrade() so that we can apply interface here

@c9s c9s requested a review from andycheng123 August 31, 2023 05:23
@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 344 BBG.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (3dca9aa) 21.28% compared to head (4a3b0bc) 21.28%.
Report is 110 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1296   +/-   ##
=======================================
  Coverage   21.28%   21.28%           
=======================================
  Files         596      596           
  Lines       43933    43933           
=======================================
  Hits         9349     9349           
  Misses      33907    33907           
  Partials      677      677           
Files Coverage Δ
pkg/strategy/xmaker/strategy.go 2.64% <0.00%> (ø)
pkg/types/profit.go 0.00% <0.00%> (ø)
pkg/types/trade_stats.go 19.10% <0.00%> (ø)
pkg/bbgo/order_executor_general.go 16.08% <0.00%> (ø)
pkg/strategy/drift/strategy.go 3.39% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dca9aa...4a3b0bc. Read the comment docs.

- rename Add() to AddProfit() or AddTrade() so that we can apply
  interface here
@c9s c9s force-pushed the feature/profit-stats branch from 046ed88 to 4a3b0bc Compare January 3, 2024 09:50
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 343 BBG

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants