Add new AMX and other feature flags #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eventually we want to make sure that all of these new flags are handled completely. Esp if we add new CPU baseline types, but for now this is fine. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added AMX and other feature flags that the compiler did not handle on my machine.
I did this following the pattern from #1482.
Since I am not sure if I added the flags correctly to the x86_features_add_feature function in target.c so I would recommend someone to look into that. Also I was unsure if I needed to add the flag to x86_initialize_cpu_features, so input on that part is also very welcome.
PS. Sorry for some seemingly unnecessary indentation changes, I was not aware my editor was messing with that.