Clear scratch_buffer in compile_and_invoke.

[zargovv]

The scratch_buffer contains erroneous data in compile_and_invoke, therefore should be cleared.

[lerno]

This fix would break execute_scripts(). This line:

(void) compile_and_invoke(scratch_buffer_to_string(), execs.len ? execs.ptr : "", NULL);

Needs to be

(void) compile_and_invoke(scratch_buffer_copy(), execs.len ? execs.ptr : "", NULL);

[lerno]

This fix addresses #1560 yes, but let's not use "closes" since that would auto-close 1560, which is not desirable. Once it is fixed, we request the reporter to check that the issue is properly fixed instead. This is an extra check.

[lerno]

I incorporated it into a fix, together with the additional lines needed. Thanks for tracking it down!

[zargovv]

This fix addresses #1560 yes, but let's not use "closes" since that would auto-close 1560, which is not desirable. Once it is fixed, we request the reporter to check that the issue is properly fixed instead. This is an extra check.

Sorry for the inconvenience caused by the pull request.

I'll keep that in mind for any future submissions. Thanks for the review!

[lerno]

No it's fine, no worries. Thank you for finding the issue!