stop using ...

c3g · Dec 20, 2024 · 91c922f · 91c922f
1 parent 87e4a6f
commit 91c922f
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/frontend/src/components/pagedItemsTable/PagedItemsTable.tsx b/frontend/src/components/pagedItemsTable/PagedItemsTable.tsx
@@ -21,7 +21,7 @@ export interface PagedItemsActionsCallbacks {
 	setFilterCallback: (value: FilterValue, description: FilterDescription) => void
 	setFilterOptionsCallback: (description: FilterDescription, options: FilterOptions) => void
 	clearFiltersCallback: () => void
-	setSortByCallback: (...sortByList: SortBy[]) => void
+	setSortByCallback: (sortByList: SortBy[]) => void
 	setPageSizeCallback: (pageSize: number) => void
 	resetPagedItemsCallback: () => void
 	setStaleCallback: (stale: boolean) => void
@@ -123,7 +123,7 @@ function PagedItemsTable<T extends object>({
 			if (!Array.isArray(sorterResult)) {
 				sorterResult = [sorterResult]
 			}
-			setSortByCallback(...sorterResult
+			setSortByCallback(sorterResult
 				.sort((a, b) => {
 					const aSorter = a.column?.sorter
 					const bSorter = b.column?.sorter

diff --git a/frontend/src/components/pagedItemsTable/serializeFilterParamsTS.ts b/frontend/src/components/pagedItemsTable/serializeFilterParamsTS.ts
@@ -105,7 +105,7 @@ export default function serializeFilterParamsWithDescriptions(filters: FilterSet
 	return params
 }
 
-export function serializeSortByParams(...sortByList: SortBy[]) {
+export function serializeSortByParams(sortByList: SortBy[]) {
 	const prefixByOrder = {
 		'ascend': '',
 		'descend': '-',
@@ -125,5 +125,5 @@ export function serializeSortByParams(...sortByList: SortBy[]) {
  * @returns 
  */
 export function filtersQueryParams(filters: FilterSet, sortByList: SortBy[]){
-	return {...serializeFilterParamsWithDescriptions(filters), ordering: serializeSortByParams(...sortByList)}
+	return {...serializeFilterParamsWithDescriptions(filters), ordering: serializeSortByParams(sortByList)}
   }
diff --git a/frontend/src/components/pagedItemsTable/usePagedItemsActionCallbacks.tsx b/frontend/src/components/pagedItemsTable/usePagedItemsActionCallbacks.tsx
@@ -39,8 +39,8 @@ export function usePagedItemsActionsCallbacks(pagedItemActions: PagedItemsAction
 			dispatch(pagedItemActions.clearFilters())
 		}
 
-		const setSortByCallback = (...sortByList: SortBy[]) => {
-				dispatch(pagedItemActions.setSortBy(...sortByList))
+		const setSortByCallback = (sortByList: SortBy[]) => {
+				dispatch(pagedItemActions.setSortBy(sortByList))
 		}
 
 		const setPageSizeCallback =(pageSize: number) => {

diff --git a/frontend/src/models/paged_items_factory.ts b/frontend/src/models/paged_items_factory.ts
@@ -37,7 +37,7 @@ export interface PagedItemsActions {
 	setFilterOptions: (description: FilterDescription, options: FilterOptions) => FreezemanAsyncThunk<void>
 	removeFilter: (description: FilterDescription) => FreezemanAsyncThunk<void>
 	clearFilters: () => FreezemanAsyncThunk<void>
-	setSortBy: (...sortByList: SortBy[]) => FreezemanAsyncThunk<void>
+	setSortBy: (sortByList: SortBy[]) => FreezemanAsyncThunk<void>
 	setPageSize: (pageSize: number) => FreezemanAsyncThunk<void>
     resetPagedItems: () => FreezemanAsyncThunk<void>
     setStale: (stale: boolean) => FreezemanAsyncThunk<void>
@@ -142,7 +142,7 @@ export function createPagedItemsActions<Prefix extends string, M extends FMSTrac
         const { filters, fixedFilters, sortByList } = pagedItems
 
         const serializedFilters = serializeFilterParamsWithDescriptions({ ...fixedFilters, ...filters })
-		const ordering = serializeSortByParams(...sortByList)
+		const ordering = serializeSortByParams(sortByList)
 
         const params = {
 			offset,
@@ -231,7 +231,7 @@ export function createPagedItemsActions<Prefix extends string, M extends FMSTrac
         return await dispatch(_fetchPage(1))
     }
 
-    const setSortBy: PagedItemsActions['setSortBy'] = (...sortByList) => async (dispatch) => {
+    const setSortBy: PagedItemsActions['setSortBy'] = (sortByList) => async (dispatch) => {
         dispatch({
             type: SET_SORT_BY,
             sortByList,
@@ -314,7 +314,7 @@ export function createPagedItemsReducer<P extends PagedItems, Prefix extends str
 				return reduceClearFilters(state)
 			}
 			case SET_SORT_BY: {
-				return reduceSetSortBy(state, ...action.sortByList)
+				return reduceSetSortBy(state, action.sortByList)
 			}
 			case SET_PAGE_SIZE: {
 				return reduceSetPageSize(state, action.pageSize)

diff --git a/frontend/src/models/paged_items_reducers.ts b/frontend/src/models/paged_items_reducers.ts
@@ -90,7 +90,7 @@ export function reduceClearFilters<P extends PagedItems>(pagedItems: P): P {
     }
 }
 
-export function reduceSetSortBy<P extends PagedItems>(pagedItems: P, ...sortByList: SortBy[]): P {
+export function reduceSetSortBy<P extends PagedItems>(pagedItems: P, sortByList: SortBy[]): P {
     return {
         ...pagedItems,
         sortByList