-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start refactor of get_profiles #124
Conversation
@jklymak is this what you had in mind to resolve #111? Recently alseamar changed the way that dives are defined on the seaexplorer to a much more sensible method. It now starts a new dive file after the first GPS fix at surface, so we should be able to use a much simpler method to define profiles. Having factored out |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 56.50% 57.60% +1.10%
==========================================
Files 9 9
Lines 1646 1630 -16
==========================================
+ Hits 930 939 +9
+ Misses 716 691 -25 ☔ View full report in Codecov by Sentry. |
fc6deb2
to
9cec8bf
Compare
@jklymak I've merged in the latest changes to main and fixed this PR for factoring out get_profiles, if that's still a goal. The commit history is a bit of a mess after getting stale, so likely better to squash and merge |
Currently refactoring out requires operating on the .nc file that was written to disk by |
I've not looked at this carefully yet, but 1) it should remain back-compatible so the raw-to-timeseries methods could still make the profile extraction work. 2) I think the profile finding already is a separate method operating on xarrays? So the to-do would be to make that function easier to access, make/lightly deprecate doing it in the raw-to-timeseries, and change the examples to use the external interface. |
I think this will require a bit more planning, especially as any change to this will need end users to update their processing scripts. I'll close this PR for now and design something that is more robust. I'm wondering if a class based approach might work better |
This will resolve Issue #111
Failing a few tests atm