-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add key 'w' to show winner(s) from voting #2
Open
lucasrangit
wants to merge
10
commits into
c-base:master
Choose a base branch
from
lucasrangit:http-votes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasrangit
force-pushed
the
http-votes
branch
from
September 23, 2018 19:12
ec1c7d1
to
4aec409
Compare
Add key 'w' to display winner(s) from [BHNT voting app](https://github.com/robotnyc/nodejs-vote-by-mac). Pressing 'w' will initiate the HTTP GET request in the background and only on success will the results be shown on the matelight. Uses `ofLoadURLAsync` to perform HTTP GET to retrieve the JSON list of winners For example, ["1"] or ["1", "10"] if there's a tie.
lucasrangit
force-pushed
the
http-votes
branch
from
September 25, 2018 14:00
c1fb534
to
017e2f3
Compare
…tening there since it makes it easier for people to connect and vote.
… keyboard was broken when infact we simply had caps lock enabled 🤦♂️
…te easy when passing the keyboard around and requires a reboot of the rpi to get the app running again.
@uwekamper I made some other changes that might be useful. |
…s how many votes are in). in the event of an HTTP error, winner and count is cleared. pressing 'r' resets the counts and aborts any pending updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add key 'w' to display winner(s) from BHNT voting app.
Pressing 'w' will initiate the HTTP GET request in the background and only on success will the
results be shown on the matelight.
Uses
ofLoadURLAsync
to perform HTTP GET to retrieve the JSON list of winnersFor example, ["1"] or ["1", "10"] if there's a tie.
Here are some screenshots with the matelight preview.
@uwekamper this is just the basics. Is this the right approach? And something the animations could be built on?