Process ReadRowsResponse with a ChunkReader #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o BT client library. Begins testing the ChunkReader against the Google acceptance tests
… all tests. will need to be manually verified when copied over to the real test file
…se the new approach. legacy tests as well as new acceptance tests all passing
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 70.35% 78.53% +8.17%
==========================================
Files 22 23 +1
Lines 253 368 +115
==========================================
+ Hits 178 289 +111
- Misses 75 79 +4
Continue to review full report at Codecov.
|
|
Awesome PR! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChunkReader
This PR resolves #8's identified issues with the ReadRowsResponse parsing logic. The issues are addressed by introducing a ChunkReader state machine handled through dynamically created GenServers. The solution is based on the reader from the official Go client library.
The ChunkReader's ability to parse a ReadRowsResponse is validated through unit tests generated using the Google read rows acceptance test JSON file provided in #8