Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have updated
test/vortex.jl
to work with the latest changes in main, and added a script under/example-vortexring.jl
with a vortex ring simulation.To run the simulation, just run the following in the terminal:
The vortex ring simulation shows that the FMM is introducing some spurious calculations that throw down the structure of the ring:
The spurious calculations become obvious at the boundaries of the clusters, and increasing the expansion order does not seem to have an effect in decreasing the error that is introduced by the FMM:
As a reference, here is the same simulation without the FMM (just the
direct!
function):It is unclear if at this point there is something wrong in the implementation of the FMM, or perhaps the FMM is introducing numerical-precision noise that throws off the symmetry of the problem. In the case of the later, there isn't much to do about it, and perhaps Pedrizzeti's relaxation would help smooth away such numerical noise.