Skip to content

Commit

Permalink
fix(extension): note timestamp catching issue
Browse files Browse the repository at this point in the history
fixes #53
  • Loading branch information
shuowu committed Jul 27, 2020
1 parent 484341e commit 740ad16
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 4 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 1.5.3

### Bug fixes

- [#53](https://github.com/shuowu/yi-note/issues/53) Fix timestamp catching issue

## 1.5.2

### Bug fixes
Expand Down
2 changes: 1 addition & 1 deletion packages/extension/manifest.common.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "YiNote",
"version": "1.5.2",
"version": "1.5.3",
"description": "Most efficient way to take & share time-stamped notes while watching videos!",
"icons": {
"16": "icons/icon-16.png",
Expand Down
2 changes: 1 addition & 1 deletion packages/extension/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@yi-note/extension",
"version": "1.5.2",
"version": "1.5.3",
"description": "Most efficient way to take & share time-stamped notes while watching videos!",
"private": false,
"keywords": [
Expand Down
5 changes: 3 additions & 2 deletions packages/extension/src/ui/services/player/HTML5Player.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ export default class HTML5Player extends Player {
throw new Error('Player initial error');
}

// TODO: move to InstagramPlayer class
// Set crossorigin attribute to enable screenshot
this.video.setAttribute('crossorigin', 'anonymous');
this.video.load();
// this.video.setAttribute('crossorigin', 'anonymous');
// this.video.load();
}

getVideoElement() {
Expand Down

0 comments on commit 740ad16

Please sign in to comment.