Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat #2

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Reformat #2

merged 5 commits into from
Jan 16, 2024

Conversation

brianjosephmckeon
Copy link
Member

No description provided.

@brianjosephmckeon
Reformatted.
b020ddf 
Removed unused code.
Added Eq and Show where they were missing.
Bumped version number.
@brianjosephmckeon
Added GH workflows.
5db5d90
@brianjosephmckeon
055e142
@brianjosephmckeon
Reformatted code.
b6262b9
@brianjosephmckeon
Copy link
Member Author

Added workflows and reformatted code.
No code changes have been made yet.
Two tests are failing, but I don't understand why.

@brianjosephmckeon
Fixed tests.
9bf220e 
Bumped primitive dependency version.
andrewthad
andrewthad approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@andrewthad andrewthad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's just adding CI, applying code formatting, and update the expected test output for changes in primitive, then this looks good to me.

@brianjosephmckeon brianjosephmckeon merged commit 2826eb7 into main Jan 16, 2024
2 checks passed
@brianjosephmckeon brianjosephmckeon deleted the reformat branch January 16, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewthad andrewthad andrewthad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianjosephmckeon @andrewthad