This repository has been archived by the owner on Dec 27, 2020. It is now read-only.
feat: Porting across the LiBo per-device protocol details #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a LiBo device that is purelly a Kegel sensor: no vibe, so no VibrateCmd in the defaults. This is the first protocol that also has additional per-device configuration that can't be resolved from the messages. To handle this now and ongoing, I propose an "extra" section that will be passed to the protocol driver: it's a freeform object for flexibility given that it's intended to be used for protocol specific tweaks that arn't generalisable.
|
@qdot I'm putting this out there early (before I go through the rest of the protocols), since I figure that my proposed "extra" block is likely to start a conversation. |
|
Just hit me that I'd want to actually do this in the subtree in C# so I can test end-to-end as I go. But I want to discuss the extra block before I go down that road. |
|
Closing this, since I'll move over to the C# subtree where I can mess with both sides at the same time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a LiBo device that is purelly a Kegel sensor: no vibe, so
no VibrateCmd in the defaults.
This is the first protocol that also has additional per-device
configuration that can't be resolved from the messages. To handle
this now and ongoing, I propose an "extra" section that will be
passed to the protocol driver: it's a freeform object for flexibility
given that it's intended to be used for protocol specific tweaks
that arn't generalisable.