Replace auto-launch with native autostart

package.json

@@ -202,7 +202,6 @@
     "@buttercup/importer": "^3.1.0",
     "@buttercup/secure-file-host": "^0.3.0",
     "@electron/remote": "^2.0.8",
-    "auto-launch": "^5.0.6",
     "buttercup": "^7.4.0",
     "debounce": "^1.2.1",
     "debounce-promise": "^3.1.2",

source/main/actions/config.ts

@@ -4,8 +4,8 @@ import { getOSLocale } from "../services/locale";
 import { changeLanguage } from "../../shared/i18n/trans";
 import { getLanguage } from "../../shared/library/i18n";
 import { startFileHost, stopFileHost } from "../services/fileHost";
+import { setStartWithSession } from "../services/launch";
 import { start as startBrowserAPI, stop as stopBrowserAPI } from "../services/browser/index";
-import { setStartWithSession } from "../services/config";
 import { Preferences } from "../types";
 
 export async function handleConfigUpdate(preferences: Preferences) {

source/main/index.ts

@@ -5,7 +5,7 @@ import { initialise } from "./services/init";
 import { openMainWindow } from "./services/windows";
 import { handleProtocolCall } from "./services/protocol";
 import { getConfigValue } from "./services/config";
-import { shouldShowMainWindow } from "./services/arguments";
+import { shouldShowMainWindow, wasAutostarted } from "./services/arguments";
 import { logErr, logInfo } from "./library/log";
 import { BUTTERCUP_PROTOCOL } from "./symbols";
 import { AppStartMode } from "./types";
@@ -74,9 +74,12 @@ app.whenReady()
     })
     .then(async () => {
         const preferences = await getConfigValue("preferences");
-        const hideInTray = preferences.startMode === AppStartMode.HiddenAlways;
-        if (!shouldShowMainWindow() || hideInTray) {
-            logInfo("Opening initial window disabled by CL or preferences");
+        const autostarted = wasAutostarted();
+        if (!shouldShowMainWindow() || preferences.startMode === AppStartMode.HiddenAlways) {
+            logInfo("Not opening initial window: disabled by CL or preferences");
+            return;
+        } else if (autostarted && preferences.startMode === AppStartMode.HiddenOnBoot) {
+            logInfo("Not opening initial window: disabled for autostart");
             return;
         }
         openMainWindow();

source/main/services/arguments.ts

@@ -1,6 +1,7 @@
 import { app } from "electron";
 
-let __showMainWindow = true;
+let __autostarted = false,
+    __showMainWindow = true;
 
 export function processCLFlags() {
     const cl = app.commandLine;
@@ -11,8 +12,15 @@ export function processCLFlags() {
     if (cl.hasSwitch("hidden")) {
         __showMainWindow = false;
     }
+    if (cl.hasSwitch("autostart")) {
+        __autostarted = true;
+    }
 }
 
 export function shouldShowMainWindow(): boolean {
     return __showMainWindow;
 }
+
+export function wasAutostarted(): boolean {
+    return __autostarted;
+}

source/main/services/config.ts

@@ -1,12 +1,11 @@
-import AutoLaunch from "auto-launch";
 import fs from "fs/promises";
 import { VaultSourceID } from "buttercup";
 import { getConfigStorage, getVaultSettingsPath, getVaultSettingsStorage } from "./storage";
 import { naiveClone } from "../../shared/library/clone";
 import { logErr, logInfo } from "../library/log";
-import { PREFERENCES_DEFAULT, VAULT_SETTINGS_DEFAULT } from "../../shared/symbols";
-import { AppStartMode, Config, Preferences, VaultSettingsLocal } from "../types";
 import { runConfigMigrations } from "./migration";
+import { PREFERENCES_DEFAULT, VAULT_SETTINGS_DEFAULT } from "../../shared/symbols";
+import { Config, VaultSettingsLocal } from "../types";
 
 const DEFAULT_CONFIG: Config = {
     browserClients: {},
@@ -81,15 +80,3 @@ export async function setVaultSettings(
     const storage = getVaultSettingsStorage(sourceID);
     await storage.setValues(settings);
 }
-
-export async function setStartWithSession(enable: boolean): Promise<void> {
-    const autoLauncher = new AutoLaunch({
-        name: "Buttercup"
-    });
-    const isEnabled = await autoLauncher.isEnabled();
-    if (enable && !isEnabled) {
-        await autoLauncher.enable();
-    } else if (!enable && isEnabled) {
-        await autoLauncher.disable();
-    }
-}

source/main/services/launch.ts

@@ -0,0 +1,16 @@
+import { app } from "electron";
+
+export async function setStartWithSession(enable: boolean): Promise<void> {
+    const isEnabled = app.getLoginItemSettings().openAtLogin;
+    if (enable && !isEnabled) {
+        app.setLoginItemSettings({
+            openAtLogin: true,
+            args: ["--autostart"]
+        });
+    } else if (!enable && isEnabled) {
+        app.setLoginItemSettings({
+            openAtLogin: false,
+            args: []
+        });
+    }
+}