a few changes to get admin area working with 3.5 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the tests setup i have is: GSTFree Shipping uses default. Add a product with GST and one without, tax looks ok in checkout |
|
If this module is going to brought up to scratch should probably be brought across to silvershop repo + composer, licence added etc as well. Any votes for supporting this? |
|
@wilr - that would be fantastic. realistically for a lot of projects tax is just wrong without the ability to have different rates per product. However - I don't think i'd be able to lead that effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possibly a step backwards. i've made some changes so dev/build runs and the admin area loads. very basic testing of tax calculations seems to show its working.