WIP: Upgrade Kotlin / KSP / Compose Multiplatform #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuel-martos
changed the title
manuel-martos
changed the title
utils/interop-ribs/lint-baseline.xml
Outdated
| <issues format="6" by="lint 7.4.1" type="baseline" client="gradle" dependencies="false" name="AGP (7.4.1)" variant="all" version="7.4.1"> | ||
|
|
||
| <issue | ||
| id="NewApi" |
There was a problem hiding this comment.
I had this issue before, it went away with agp update
There was a problem hiding this comment.
Which AGP version should remove this false positive?
There was a problem hiding this comment.
I think it wasn't a specific version but rather combination kotlin + agp
| @@ -9,16 +9,16 @@ androidTargetSdk = "32" | |||
| androidx-lifecycle = "2.6.1" | |||
| androidx-navigation-compose = "2.5.1" | |||
| coil = "2.2.1" | |||
| composePlugin = "1.4.0" | |||
| composePlugin = "1.5.0" | |||
There was a problem hiding this comment.
but we can't update it without updating google compose to 1.5? And compose update at the main project is currently blocked
|
Closing as done with even later versions in #662 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #547
Check list
CHANGELOG.mdif required.