Update lint version and baselines

bumble-tech · Apr 15, 2024 · df43eb7 · df43eb7
1 parent 35cada5
commit df43eb7
Show file tree

Hide file tree

Showing 5 changed files with 93 additions and 104 deletions.
diff --git a/gradle.properties b/gradle.properties
@@ -4,3 +4,4 @@ org.gradle.parallel=true
 android.useAndroidX=true
 kotlin.code.style=official
 library.version=1.4.1-migrate-2.x
+android.experimental.lint.version=8.3.0
diff --git a/libraries/core/lint-baseline.xml b/libraries/core/lint-baseline.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<issues format="6" by="lint 7.1.3" type="baseline" client="gradle" dependencies="false" name="AGP (7.1.3)" variant="all" version="7.1.3">
+<issues format="6" by="lint 8.3.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.2.2)" variant="all" version="8.3.0">
 
     <issue
         id="ComposableNaming"
@@ -8,7 +8,7 @@
         errorLine2="                      ~~~~~~~~">
         <location
             file="src/main/kotlin/com/bumble/appyx/core/composable/Children.kt"
-            line="90"
+            line="92"
             column="23"/>
     </issue>
 
@@ -19,7 +19,7 @@
         errorLine2="                      ~~~~~~~~">
         <location
             file="src/main/kotlin/com/bumble/appyx/core/composable/Children.kt"
-            line="102"
+            line="104"
             column="23"/>
     </issue>
 
@@ -30,7 +30,7 @@
         errorLine2="                              ~~~~~~~~~">
         <location
             file="src/main/kotlin/com/bumble/appyx/core/composable/Children.kt"
-            line="118"
+            line="120"
             column="31"/>
     </issue>
 

diff --git a/samples/app/lint-baseline.xml b/samples/app/lint-baseline.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<issues format="6" by="lint 7.1.3" type="baseline" client="gradle" dependencies="false" name="AGP (7.1.3)" variant="all" version="7.1.3">
+<issues format="6" by="lint 8.3.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.2.2)" variant="all" version="8.3.0">
 
     <issue
         id="UnnecessaryComposedModifier"
@@ -8,8 +8,41 @@
         errorLine2="    ~~~~~~~~">
         <location
             file="src/main/kotlin/com/bumble/appyx/app/composable/DashedBorder.kt"
-            line="84"
+            line="85"
             column="5"/>
     </issue>
 
+    <issue
+        id="AutoboxingStateCreation"
+        message="Prefer `mutableIntStateOf` instead of `mutableStateOf`"
+        errorLine1="    private var counter by mutableStateOf("
+        errorLine2="                           ~~~~~~~~~~~~~~">
+        <location
+            file="src/main/kotlin/com/bumble/appyx/app/node/child/GenericChildNode.kt"
+            line="78"
+            column="28"/>
+    </issue>
+
+    <issue
+        id="AutoboxingStateCreation"
+        message="Prefer `mutableIntStateOf` instead of `mutableStateOf`"
+        errorLine1="    private var colorIndex by mutableStateOf("
+        errorLine2="                              ~~~~~~~~~~~~~~">
+        <location
+            file="src/main/kotlin/com/bumble/appyx/app/node/child/GenericChildNode.kt"
+            line="81"
+            column="31"/>
+    </issue>
+
+    <issue
+        id="AutoboxingStateCreation"
+        message="Prefer `mutableIntStateOf` instead of `mutableStateOf`"
+        errorLine1="                var counter by remember { mutableStateOf(105) }"
+        errorLine2="                                          ~~~~~~~~~~~~~~">
+        <location
+            file="src/main/kotlin/com/bumble/appyx/app/node/slideshow/slide/app/StatefulNode2.kt"
+            line="73"
+            column="43"/>
+    </issue>
+
 </issues>
diff --git a/samples/common/lint-baseline.xml b/samples/common/lint-baseline.xml
@@ -1,81 +1,46 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<issues format="6" by="lint 7.2.2" type="baseline" client="gradle" dependencies="false" name="AGP (7.2.2)" variant="all" version="7.2.2">
+<issues format="6" by="lint 8.3.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.2.2)" variant="all" version="8.3.0">
 
     <issue
-        id="UnusedResources"
-        message="The resource `R.color.black` appears to be unused"
-        errorLine1="    &lt;color name=&quot;black&quot;>#FF000000&lt;/color>"
-        errorLine2="           ~~~~~~~~~~~~">
-        <location
-            file="src/main/res/values/colors.xml"
-            line="3"
-            column="12"/>
-    </issue>
-
-    <issue
-        id="UnusedResources"
-        message="The resource `R.color.appyx_yellow1` appears to be unused"
-        errorLine1="    &lt;color name=&quot;appyx_yellow1&quot;>#FFFFC629&lt;/color>"
-        errorLine2="           ~~~~~~~~~~~~~~~~~~~~">
+        id="IconLocation"
+        message="Found bitmap drawable `res/drawable/halloween10.jpeg` in densityless folder">
         <location
-            file="src/main/res/values/colors.xml"
-            line="5"
-            column="12"/>
+            file="src/main/res/drawable/halloween10.jpeg"/>
     </issue>
 
     <issue
-        id="UnusedResources"
-        message="The resource `R.color.appyx_yellow2` appears to be unused"
-        errorLine1="    &lt;color name=&quot;appyx_yellow2&quot;>#FFFFE54A&lt;/color>"
-        errorLine2="           ~~~~~~~~~~~~~~~~~~~~">
+        id="IconLocation"
+        message="Found bitmap drawable `res/drawable/halloween11.jpeg` in densityless folder">
         <location
-            file="src/main/res/values/colors.xml"
-            line="6"
-            column="12"/>
+            file="src/main/res/drawable/halloween11.jpeg"/>
     </issue>
 
     <issue
-        id="UnusedResources"
-        message="The resource `R.color.appyx_dark` appears to be unused"
-        errorLine1="    &lt;color name=&quot;appyx_dark&quot;>#FF1F2126&lt;/color>"
-        errorLine2="           ~~~~~~~~~~~~~~~~~">
+        id="IconLocation"
+        message="Found bitmap drawable `res/drawable/halloween12.jpeg` in densityless folder">
         <location
-            file="src/main/res/values/colors.xml"
-            line="7"
-            column="12"/>
+            file="src/main/res/drawable/halloween12.jpeg"/>
     </issue>
 
     <issue
-        id="UnusedResources"
-        message="The resource `R.color.appyx_bright` appears to be unused"
-        errorLine1="    &lt;color name=&quot;appyx_bright&quot;>#FFFFFFFF&lt;/color>"
-        errorLine2="           ~~~~~~~~~~~~~~~~~~~">
+        id="IconLocation"
+        message="Found bitmap drawable `res/drawable/halloween13.jpeg` in densityless folder">
         <location
-            file="src/main/res/values/colors.xml"
-            line="8"
-            column="12"/>
+            file="src/main/res/drawable/halloween13.jpeg"/>
     </issue>
 
     <issue
-        id="UnusedResources"
-        message="The resource `R.style.Theme_Appyx` appears to be unused"
-        errorLine1="    &lt;style name=&quot;Theme.Appyx&quot; parent=&quot;Theme.MaterialComponents.DayNight.DarkActionBar&quot;>"
-        errorLine2="           ~~~~~~~~~~~~~~~~~~">
+        id="IconLocation"
+        message="Found bitmap drawable `res/drawable/halloween14.jpeg` in densityless folder">
         <location
-            file="src/main/res/values/themes.xml"
-            line="3"
-            column="12"/>
+            file="src/main/res/drawable/halloween14.jpeg"/>
     </issue>
 
     <issue
-        id="UnusedResources"
-        message="The resource `R.style.Theme_Appyx_NoActionBar` appears to be unused"
-        errorLine1="    &lt;style name=&quot;Theme.Appyx.NoActionBar&quot;>"
-        errorLine2="           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        id="IconLocation"
+        message="Found bitmap drawable `res/drawable/halloween15.jpeg` in densityless folder">
         <location
-            file="src/main/res/values/themes.xml"
-            line="17"
-            column="12"/>
+            file="src/main/res/drawable/halloween15.jpeg"/>
     </issue>
 
     <issue
@@ -120,47 +85,4 @@
             file="src/main/res/drawable/halloween9.jpeg"/>
     </issue>
 
-    <issue
-        id="IconLocation"
-        message="Found bitmap drawable `res/drawable/halloween10.jpeg` in densityless folder">
-        <location
-            file="src/main/res/drawable/halloween10.jpeg"/>
-    </issue>
-
-    <issue
-        id="IconLocation"
-        message="Found bitmap drawable `res/drawable/halloween11.jpeg` in densityless folder">
-        <location
-            file="src/main/res/drawable/halloween11.jpeg"/>
-    </issue>
-
-    <issue
-        id="IconLocation"
-        message="Found bitmap drawable `res/drawable/halloween12.jpeg` in densityless folder">
-        <location
-            file="src/main/res/drawable/halloween12.jpeg"/>
-    </issue>
-
-    <issue
-        id="IconLocation"
-        message="Found bitmap drawable `res/drawable/halloween13.jpeg` in densityless folder">
-        <location
-            file="src/main/res/drawable/halloween13.jpeg"/>
-    </issue>
-
-    <issue
-        id="IconLocation"
-        message="Found bitmap drawable `res/drawable/halloween14.jpeg` in densityless folder">
-        <location
-            file="src/main/res/drawable/halloween14.jpeg"/>
-    </issue>
-
-    <issue
-        id="IconLocation"
-        message="Found bitmap drawable `res/drawable/halloween15.jpeg` in densityless folder">
-        <location
-            file="src/main/res/drawable/halloween15.jpeg"/>
-    </issue>
-
-
 </issues>
diff --git a/samples/sandbox/lint-baseline.xml b/samples/sandbox/lint-baseline.xml
@@ -1,5 +1,38 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<issues format="6" by="lint 7.4.0" type="baseline" client="gradle" dependencies="false" name="AGP (7.4.0)" variant="all" version="7.4.0">
+<issues format="6" by="lint 8.3.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.2.2)" variant="all" version="8.3.0">
+
+    <issue
+        id="PermissionImpliesUnsupportedChromeOsHardware"
+        message="Permission exists without corresponding hardware `&lt;uses-feature android:name=&quot;android.hardware.camera&quot; required=&quot;false&quot;>` tag"
+        errorLine1="    &lt;uses-permission android:name=&quot;android.permission.CAMERA&quot; />"
+        errorLine2="     ~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/AndroidManifest.xml"
+            line="4"
+            column="6"/>
+    </issue>
+
+    <issue
+        id="AutoboxingStateCreation"
+        message="Prefer `mutableLongStateOf` instead of `mutableStateOf`"
+        errorLine1="        var lastToastClickTime by remember { mutableStateOf(0L) }"
+        errorLine2="                                             ~~~~~~~~~~~~~~">
+        <location
+            file="src/main/kotlin/com/bumble/appyx/sandbox/client/blocker/BlockerExampleNode.kt"
+            line="98"
+            column="46"/>
+    </issue>
+
+    <issue
+        id="AutoboxingStateCreation"
+        message="Prefer `mutableIntStateOf` instead of `mutableStateOf`"
+        errorLine1="                    var counter by rememberSaveable { mutableStateOf(0) }"
+        errorLine2="                                                      ~~~~~~~~~~~~~~">
+        <location
+            file="src/main/kotlin/com/bumble/appyx/sandbox/client/child/ChildNode.kt"
+            line="93"
+            column="55"/>
+    </issue>
 
     <issue
         id="Overdraw"