Merge pull request #611 from zsoltk/lower-spring-thresholds

Lower position and rotation animation default round-off thresholds
bumble-tech · Oct 6, 2023 · 2f57e81 · 2f57e81
2 parents ccc0dee + 3ad2679
commit 2f57e81
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,14 +2,20 @@
 
 ## Pending changes
 
-–
+### Changed
+
+- [#611](https://github.com/bumble-tech/appyx/pull/611) – Lower position and rotation animation default round-off thresholds
+
+---
 
 ## 2.0.0-alpha08
 
 ### Fixed
 
 - [#608](https://github.com/bumble-tech/appyx/pull/608) – Setting default value to NodeCustomisationDirectory in IosNodeHost
 
+---
+
 ## 2.0.0-alpha07
 
 ### Added
@@ -19,6 +25,7 @@
 
 <div style="text-align: center"><small>4 Oct 2023</small></div>
 
+---
 
 ## 2.0.0-alpha06
 

diff --git a/...on/src/commonMain/kotlin/com/bumble/appyx/interactions/core/ui/property/impl/RotationX.kt b/...on/src/commonMain/kotlin/com/bumble/appyx/interactions/core/ui/property/impl/RotationX.kt
@@ -21,7 +21,7 @@ import kotlinx.coroutines.flow.StateFlow
 class RotationX(
     coroutineScope: CoroutineScope,
     target: Target,
-    visibilityThreshold: Float = 1f,
+    visibilityThreshold: Float = 0.1f,
     displacement: StateFlow<Float> = MutableStateFlow(0f),
     private val origin: TransformOrigin = target.origin,
 ) : MotionProperty<Float, AnimationVector1D>(

diff --git a/...on/src/commonMain/kotlin/com/bumble/appyx/interactions/core/ui/property/impl/RotationY.kt b/...on/src/commonMain/kotlin/com/bumble/appyx/interactions/core/ui/property/impl/RotationY.kt
@@ -21,7 +21,7 @@ import kotlinx.coroutines.flow.StateFlow
 class RotationY(
     coroutineScope: CoroutineScope,
     target: Target,
-    visibilityThreshold: Float = 1f,
+    visibilityThreshold: Float = 0.1f,
     displacement: StateFlow<Float> = MutableStateFlow(0f),
     private val origin: TransformOrigin = target.origin,
 ) : MotionProperty<Float, AnimationVector1D>(

diff --git a/...on/src/commonMain/kotlin/com/bumble/appyx/interactions/core/ui/property/impl/RotationZ.kt b/...on/src/commonMain/kotlin/com/bumble/appyx/interactions/core/ui/property/impl/RotationZ.kt
@@ -21,7 +21,7 @@ import kotlinx.coroutines.flow.StateFlow
 class RotationZ(
     coroutineScope: CoroutineScope,
     target: Target,
-    visibilityThreshold: Float = 1f,
+    visibilityThreshold: Float = 0.1f,
     displacement: StateFlow<Float> = MutableStateFlow(0f),
     private val origin: TransformOrigin = target.origin,
 ) : MotionProperty<Float, AnimationVector1D>(

diff --git a/...ain/kotlin/com/bumble/appyx/interactions/core/ui/property/impl/position/PositionInside.kt b/...ain/kotlin/com/bumble/appyx/interactions/core/ui/property/impl/position/PositionInside.kt
@@ -29,7 +29,7 @@ class PositionInside(
     coroutineScope: CoroutineScope,
     val target: Target,
     displacement: StateFlow<Value> = MutableStateFlow(Value.Zero),
-    visibilityThreshold: Value = Value(InsideAlignment(0.01f, 0.01f), DpOffset(1.dp, 1.dp)),
+    visibilityThreshold: Value = Value(InsideAlignment(0.001f, 0.001f), DpOffset(1.dp, 1.dp)),
 ) : MotionProperty<Value, AnimationVector4D>(
     coroutineScope = coroutineScope,
     animatable = Animatable(target.value, Value.VectorConverter),

diff --git a/...in/kotlin/com/bumble/appyx/interactions/core/ui/property/impl/position/PositionOutside.kt b/...in/kotlin/com/bumble/appyx/interactions/core/ui/property/impl/position/PositionOutside.kt
@@ -28,7 +28,7 @@ class PositionOutside(
     coroutineScope: CoroutineScope,
     val target: Target,
     displacement: StateFlow<Value> = MutableStateFlow(Value.Zero),
-    visibilityThreshold: Value = Value(OutsideAlignment(0.01f, 0.01f), DpOffset(1.dp, 1.dp)),
+    visibilityThreshold: Value = Value(OutsideAlignment(0.001f, 0.001f), DpOffset(1.dp, 1.dp)),
 ) : MotionProperty<Value, AnimationVector4D>(
     coroutineScope = coroutineScope,
     animatable = Animatable(target.value, Value.VectorConverter),