Export Run Image Metadata #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maintainers, As you review this RFC please queue up issues to be created using the following commands: Issues(none) |
Signed-off-by: Joey Brown <[email protected]>
joeybrown-sf
force-pushed
the
extend-report-toml
branch
from
ddb1828 to
6c56aa2
Compare
Signed-off-by: Joey Brown <[email protected]>
joeybrown-sf
force-pushed
the
extend-report-toml
branch
from
eba0bcf to
0af349b
Compare
Signed-off-by: Joey Brown <[email protected]>
joeybrown-sf
force-pushed
the
extend-report-toml
branch
from
8dd588f to
7ccbed1
Compare
| - Rebase process may remain suboptimal for some platform providers. | ||
|
|
||
| 2. Write all the metadata labels to `report.toml`. | ||
| - This could break platform operators that are using the `terminationMessagePath` [pattern](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#pod-v1-core). Because some of the metadata includes unbounded arrays, we could explode this report beyond the max size of 4096 bytes. |
There was a problem hiding this comment.
@tomkennedy513 do you have any feedback here?
There was a problem hiding this comment.
FWIW I don't think we're close to hitting the limit yet (though it's been said before...)
There was a problem hiding this comment.
IIRC kpack doesn't blindly dump the report.toml directly, it parses out only the stuff it cares about and writes that to terminationMessagePath instead.
I don't think we've encountered any issues with length yet, but I image that's because we limit the unbounded array to just the id, version, and homepage metadata of buildpacks.
Signed-off-by: Joey Brown <[email protected]>
natalieparellano
approved these changes
May 23, 2024
jabrown85
approved these changes
Jun 13, 2024
…n-image-metadata.md Updating for merge Signed-off-by: Jesse Brown <[email protected]> Signed-off-by: Jesse Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readable