Skip to content

Commit

Permalink
Merge pull request #270 from buildpacks/specify-tracking-issue
Browse files Browse the repository at this point in the history
Specify that creating a tracking issue is a step in the merge process
  • Loading branch information
sambhav authored Jan 22, 2023
2 parents 7fc2809 + e72839d commit a3a4af3
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,13 @@ Once an RFC has been accepted, the sub-team maintainers should:
Once an `issues-created/<sub-team>` label has been created for each sub-team, the RFC is ready to merge. The team member who merges the pull request should do the following:

1. Assign an id based off the pull request number.
1. Rename the file based off the ID inside `text/`.
1. Fill in the remaining metadata at the top.
1. Commit everything.
1. Update issues with RFC ID and a link to the text file.
1. Update any links in PR description to point at the committed file.
1. Remove the "Final Comment Period" label.
2. Rename the file based off the ID inside `text/`.
3. Fill in the remaining metadata at the top.
4. Commit everything.
5. Update issues with RFC ID and a link to the text file.
6. Update any links in PR description to point at the committed file.
7. Remove the "status/voting" label.
8. Create a [tracking issue](https://github.com/buildpacks/rfcs/issues/new?assignees=&labels=type%2Ftracking&template=tracking.md&title=%5BRFC+%23%3CINSERT+RFC+NUMBER+-+e.g.%2C+0099%3E%5D+-+%3CINSERT+RFC+TITLE%3E).

## Automation

Expand All @@ -60,4 +61,6 @@ The `merge-rfc.sh` script automates several steps of the merge process for accep
```
Each `<issue>` should be of the form `<org>/<repo>#<number>` (e.g. `buildpacks/spec#1`). In the rare case that no work must be done in the project as a result of the RFC pass the `-n` flag to explicitly indicate that no issues should be linked.

After running the `merge-rfc.sh` script, manually verify the output before pushing changes.
After running the `merge-rfc.sh` script:
* Manually verify the output before pushing changes.
* Create a [tracking issue](https://github.com/buildpacks/rfcs/issues/new?assignees=&labels=type%2Ftracking&template=tracking.md&title=%5BRFC+%23%3CINSERT+RFC+NUMBER+-+e.g.%2C+0099%3E%5D+-+%3CINSERT+RFC+TITLE%3E).

0 comments on commit a3a4af3

Please sign in to comment.