Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating docker base image to use go 1.22 #2171

Merged
merged 1 commit into from
May 30, 2024

Conversation

jjbustamante
Copy link
Member

@jjbustamante jjbustamante commented May 30, 2024

Summary

After releasing pack 0.34.0 our CI/CD workflow failed to publish in docker registry because our base image is using docker 1.20, this PR fixes that. Also, the CI/CD failed deploying to ubuntu lunar, but this version reached its end of life in January 25 2024, I am removing it because we don't need to support it anymore.

Output

Before

Error:

> [linux/amd64 builder 4/4] RUN make build:
14.04 go: downloading github.com/beorn7/perks v1.0.1
14.05 go: downloading github.com/cespare/xxhash/v2 v2.2.0
14.06 go: downloading github.com/prometheus/client_model v0.5.0
14.09 go: downloading github.com/prometheus/common v0.48.0
14.10 go: downloading github.com/prometheus/procfs v0.12.0
30.24 /go/pkg/mod/go.opentelemetry.io/[email protected]/attribute/set.go:7:2: package cmp is not in GOROOT (/usr/local/go/src/cmp)
30.24 note: imported by a module that requires go 1.21
30.24 /go/pkg/mod/go.opentelemetry.io/[email protected]/attribute/set.go:10:2: package slices is not in GOROOT (/usr/local/go/src/slices)
30.24 note: imported by a module that requires go 1.21
30.24 make: *** [Makefile:61: build] Error 1
------
Dockerfile:8
--------------------
   6 |     WORKDIR /app
   7 |     COPY . .
   8 | >>> RUN make build
   9 |     
  10 |     FROM ${base_image}
--------------------
ERROR: failed to solve: process "/bin/sh -c make build" did not complete successfully: exit code: 2
Error: Process completed with exit code 1.

After

Running docker build works

Resolves #2172
Resoves #2156

…unar becase it is deprecated, we don't need to support it anymore

Signed-off-by: Juan Bustamante <[email protected]>
@jjbustamante jjbustamante added the type/chore Issue that requests non-user facing changes. label May 30, 2024
@github-actions github-actions bot added this to the 0.34.0 milestone May 30, 2024
@jjbustamante jjbustamante modified the milestones: 0.34.0, 0.34.1 May 30, 2024
@jjbustamante jjbustamante marked this pull request as ready for review May 30, 2024 17:34
@jjbustamante jjbustamante requested review from a team as code owners May 30, 2024 17:34
@jjbustamante jjbustamante merged commit 98f0eb4 into main May 30, 2024
18 of 20 checks passed
@jjbustamante jjbustamante deleted the chore/fix-delivery-for-pack-0_34_0 branch May 30, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pack 0.34.0 was not released in Dockerhub
1 participant