-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buildpacksio/pack:<version>-base images to delivery #1951
Conversation
@@ -16,12 +16,21 @@ on: | |||
default: false | |||
|
|||
env: | |||
BUILDER: "paketobuildpacks/builder-jammy-tiny" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed since we don't use the pack action to build pack.
FROM golang:1.20 as builder | ||
ARG pack_version | ||
ENV PACK_VERSION=$pack_version | ||
WORKDIR /app | ||
COPY . . | ||
RUN make build | ||
|
||
FROM scratch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We base the lifecycle image on gcr.io/distroless/static, so it might make sense here as well. It's not as small as scratch but it avoids the need for branching logic in the Dockerfile.
Signed-off-by: Natalie Arellano <[email protected]>
675dca1
to
074586f
Compare
Tested on fork, this appears to work fine: https://github.com/natalieparellano/pack/actions/runs/6670247077
|
Perhaps there's a better tagging schema vs |
Signed-off-by: Natalie Arellano <[email protected]>
I imagine folks using a "base" image will want a floating tag for the latest version, so I added 01fbd91 |
Signed-off-by: Joe Kutner <[email protected]>
Summary
I still need to test this out end-to-end but I think this should resolve #1554 by adding a pack image based on ubuntu:jammy to our delivery pipeline.
Output
Before
We publish:
After
We publish:
Documentation
Related
Resolves #1554