Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run ci on PRs to release branches #1349

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Run ci on PRs to release branches #1349

merged 1 commit into from
Oct 13, 2023

Conversation

tomkennedy513
Copy link
Collaborator

No description provided.

@tomkennedy513 tomkennedy513 requested a review from a team as a code owner October 9, 2023 15:56
@chenbh
Copy link
Contributor

chenbh commented Oct 13, 2023

Don't we already run the unit tests on PRs? Why do we need to full suite?

@chenbh
Copy link
Contributor

chenbh commented Oct 13, 2023

Oh is the expectation that since PRs to release branches are always from this repo, they will always have the correct creds to run the full suite?

@tomkennedy513
Copy link
Collaborator Author

Ya I am trying to avoid ever having the release branch in a non releasable state

@tomkennedy513
Copy link
Collaborator Author

Only maintainers can make prs to release branches so it will always happen from the repo

@tomkennedy513 tomkennedy513 merged commit 41841a4 into main Oct 13, 2023
3 checks passed
@tomkennedy513 tomkennedy513 deleted the tomkennedy513-patch-1 branch October 13, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambhav sambhav sambhav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomkennedy513 @chenbh @sambhav