Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloning with Azure DevOps Git #1337

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix cloning with Azure DevOps Git #1337

merged 1 commit into from
Oct 3, 2023

Conversation

tomkennedy513
Copy link
Collaborator

@tomkennedy513 tomkennedy513 commented Oct 2, 2023

fixes #1336

@tomkennedy513 tomkennedy513 requested a review from a team as a code owner October 2, 2023 15:12
@codecov-commenter
Copy link

Codecov Report

Merging #1337 (2a2a526) into main (4d30b2a) will increase coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is 94.73%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
+ Coverage   67.41%   67.43%   +0.02%     
==========================================
  Files         133      133              
  Lines        8093     8098       +5     
==========================================
+ Hits         5456     5461       +5     
  Misses       2200     2200              
  Partials      437      437              
Files Coverage Δ
pkg/blob/fetch.go 58.90% <100.00%> (ø)
pkg/cnb/build_metadata.go 57.89% <100.00%> (ø)
pkg/cnb/env_vars.go 84.00% <100.00%> (ø)
pkg/dockercreds/parse_secrets.go 59.21% <100.00%> (ø)
pkg/git/fetch.go 63.63% <100.00%> (+2.98%) ⬆️
pkg/registry/fetch.go 49.61% <100.00%> (ø)
pkg/secret/volume_secret_reader.go 67.56% <100.00%> (ø)
pkg/notary/repository.go 0.00% <0.00%> (ø)

- remove multi_ack and multi_ack_detailed from unsupported capabilities
- see https://github.com/go-git/go-git/blob/52c2972976737a00fce91d7deb1278a6a460cae6/_examples/azure_devops/main.go\#L21-L36 for more info
- we should be able to remove this once go-git implements full support for v2 git with multi_ack

fixes #1336

Signed-off-by: Tom Kennedy <[email protected]>
@sambhav sambhav merged commit b8c0d49 into main Oct 3, 2023
3 checks passed
@sambhav sambhav deleted the fix-azure-devops branch October 3, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloning fails with Azure DevOps repos
3 participants