Clean subpath to ensure dots are handled properly

pkg/git/remote_git_resolver.go

@@ -1,6 +1,7 @@
 package git
 
 import (
+	"path"
 	"regexp"
 	"strings"
 
@@ -22,6 +23,10 @@ func (*remoteGitResolver) Resolve(auth transport.AuthMethod, sourceConfig corev1
 	var resolvedConfig corev1alpha1.ResolvedSourceConfig
 	var err error
 
+	if sourceConfig.SubPath == "." {
+		sourceConfig.SubPath = ""
+	}
+
 	if sourceConfig.SubPath != "" {
 		resolvedConfig, err = resolveSourceWithSubpath(auth, sourceConfig)
 	} else {
@@ -97,7 +102,7 @@ func resolveSourceWithSubpath(auth transport.AuthMethod, sourceConfig corev1alph
 			effectiveCommit := ""
 
 			if refSourceType == corev1alpha1.Branch {
-				effectiveCommit, err = latestCommitForSubpath(r, sourceConfig.SubPath)
+				effectiveCommit, err = latestCommitForSubpath(r, path.Clean(sourceConfig.SubPath))
 			} else {
 				effectiveCommit = ref.Hash().String()
 			}

pkg/git/remote_git_resolver_test.go

@@ -72,6 +72,29 @@ func testRemoteGitResolver(t *testing.T, when spec.G, it spec.S) {
 			})
 		})
 
+		when("source is a branch with latest commit and a . subpath", func() {
+			it("returns branch with resolved commit", func() {
+				gitResolver := remoteGitResolver{}
+
+				resolvedGitSource, err := gitResolver.Resolve(anonymousAuth, corev1alpha1.SourceConfig{
+					Git: &corev1alpha1.Git{
+						URL:      url,
+						Revision: "master",
+					},
+					SubPath: ".",
+				})
+				require.NoError(t, err)
+
+				assert.Equal(t, corev1alpha1.ResolvedSourceConfig{
+					Git: &corev1alpha1.ResolvedGitSource{
+						URL:      url,
+						Revision: fixtureHEADMasterCommit,
+						Type:     corev1alpha1.Branch,
+					},
+				}, resolvedGitSource)
+			})
+		})
+
 		when("source is a branch with older subpath", func() {
 			it("returns branch with resolved commit", func() {
 				gitResolver := remoteGitResolver{}