Skip to content

Commit

Permalink
Don't wait for the lifecycle config map informer to be ready,
Browse files Browse the repository at this point in the history
it will never be ready

Signed-off-by: Natalie Arellano <[email protected]>
  • Loading branch information
natalieparellano committed Jun 6, 2024
1 parent 2085772 commit 905ea8e
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions cmd/controller/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import (
"knative.dev/pkg/metrics"
"knative.dev/pkg/profiling"
"knative.dev/pkg/signals"
"knative.dev/pkg/system"

"github.com/pivotal/kpack/cmd"
_ "github.com/pivotal/kpack/internal/logrus/fatal"
Expand Down Expand Up @@ -147,12 +146,6 @@ func main() {
if err != nil {
log.Fatalf("could not create k8s keychain factory: %s", err)
}
lifecycleConfigmapInformerFactory := informers.NewSharedInformerFactoryWithOptions(
k8sClient,
options.ResyncPeriod,
informers.WithNamespace(system.Namespace()),
)
lifecycleConfigmapInformer := lifecycleConfigmapInformerFactory.Core().V1().ConfigMaps()

metadataRetriever := &cnb.RemoteMetadataRetriever{
ImageFetcher: &registry.Client{},
Expand Down Expand Up @@ -235,15 +228,13 @@ func main() {
stopChan := make(chan struct{})
informerFactory.Start(stopChan)
k8sInformerFactory.Start(stopChan)
lifecycleConfigmapInformerFactory.Start(stopChan)

waitForSync(stopChan,
buildInformer.Informer(),
imageInformer.Informer(),
sourceResolverInformer.Informer(),
pvcInformer.Informer(),
podInformer.Informer(),
lifecycleConfigmapInformer.Informer(),
builderInformer.Informer(),
buildpackInformer.Informer(),
clusterBuilderInformer.Informer(),
Expand Down

0 comments on commit 905ea8e

Please sign in to comment.