Merge pull request #64 from buildkite-plugins/SUP-1248

SUP-1248: Use process substitution to hide auth token
buildkite-plugins · Jan 9, 2024 · b0caed3 · b0caed3
2 parents fb7da5d + 0afd299
commit b0caed3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/hooks/pre-exit b/hooks/pre-exit
@@ -137,9 +137,7 @@ upload() {
     echo curl "${curl_args[@]}"
   fi
 
-  curl_args+=("-H" "Authorization: Token token=\"$TOKEN_VALUE\"")
-
-  curl "${curl_args[@]}"
+  curl "${curl_args[@]}" -H @<(printf 'Authorization: Token token=\"%s\"\n' "${TOKEN_VALUE}")
 }
 
 # Runs the whole plugin logic for a particular find pattern

diff --git a/tests/pre-exit-report-link.bats b/tests/pre-exit-report-link.bats
@@ -76,6 +76,7 @@ COMMON_CURL_OPTIONS='--form \* --form \* --form \* --form \* --form \* --form \*
   assert_output --partial "Uploading './tests/fixtures/junit-1.xml'..."
   assert_output --partial "Uploading './tests/fixtures/junit-2.xml'..."
   assert_output --partial "curl success 1"
+  assert_output --partial "curl success 2"
   assert_output --partial "curl success 3"
   assert_output --partial "Got 1 report URLs."
   assert_output --partial "annotation success"
@@ -104,6 +105,7 @@ COMMON_CURL_OPTIONS='--form \* --form \* --form \* --form \* --form \* --form \*
   assert_output --partial "Uploading './tests/fixtures/junit-1.xml'..."
   assert_output --partial "Uploading './tests/fixtures/junit-3.xml'..."
   assert_output --partial "curl success 1"
+  assert_output --partial "curl success 2"
   assert_output --partial "curl success 3"
   assert_output --partial "Got 2 report URLs."
   assert_output --partial "- [Report #1](https://buildkite.com/organizations/example/analytics/suites/collector-test/runs/1)"