Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernise browser packages #2224

Draft
wants to merge 47 commits into
base: next
Choose a base branch
from
Draft

Modernise browser packages #2224

wants to merge 47 commits into from

Conversation

gingerbenw
Copy link
Member

@gingerbenw gingerbenw commented Oct 16, 2024

Goal

Convert packages to TypeScript using rollup to bundle both ES modules and Common JS modules for maximum compatibility

Changeset

  • Install and configure rollup
  • Add type annotations to browser packages
  • Update build scripts to generate es modules

Testing

Covered by CI

Outstanding

  • Test tree shaking manually

@gingerbenw gingerbenw changed the title Convert packages to typescript and es modules Convert packages to TypeScript and ES Modules Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.89 kB 13.78 kB
After 46.13 kB 13.85 kB
± ⚠️ +243 bytes ⚠️ +66 bytes

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 15622fb

@gingerbenw gingerbenw force-pushed the integration/typescript branch 2 times, most recently from 0b18a5e to 25ca84e Compare October 24, 2024 10:23
@gingerbenw gingerbenw changed the title Convert packages to TypeScript and ES Modules Modernise browser packages Oct 25, 2024
gingerbenw and others added 25 commits November 12, 2024 15:38
* refactor: ♻️ convert plugin-window-onerror to typescript

* update rollup configuration

* Convert plugin-browser-request to TypeScript

* changed tsconfig

* fix: 🩹 update main entry from ts to js

* fix: 🩹 add missing external dependencies to rollup config

* chore: 🏷️ update types and remove ts-expect-error comments

* remove unnecessary rollup config

* chore: 🏷️ fix types

* chore: 🔥 remove IE8 workaround code

* fix: 🩹 fix RN init command

---------

Co-authored-by: Ben Wilson <[email protected]>
* refactor: ♻️ convert plugin-window-onerror to typescript

* update rollup configuration

* Convert plugin-browser-request to TypeScript

* changed tsconfig

* fix: 🩹 update main entry from ts to js

* fix: 🩹 add missing external dependencies to rollup config

* chore: 🏷️ update types and remove ts-expect-error comments

* remove unnecessary rollup config

* refactor: ♻️ convert plugin-window-onerror to typescript

* update rollup configuration

* Convert plugin-browser-context to TypeScript

* fix: add missing dependencies

* fix: rollup

* fix: rollup for plugin-window-onerror

* fix

* fix: unhandled rejection

* fix: type error

* chore: 🏷️ fix types

* Revert "fix: type error"

This reverts commit b314bf8.

* chore: 🔥 remove IE8 workaround code

* fix: 🩹 fix RN init command

---------

Co-authored-by: Ben Wilson <[email protected]>
Co-authored-by: Ben Wilson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants