BP-3478-Payment-fee-is-not-working-for-BNPL-methods-Billink-Riverty-Klarna #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harli91
suggested changes
Mar 19, 2024
| { text: t('3 = Zero rate'), value: '3' }, | ||
| { text: t('4 = Null rate'), value: '4' }, | ||
| { text: t('5 = Middle rate'), value: '5' }, | ||
| { text: t('21%'), value: '21' }, |
There was a problem hiding this comment.
Why do you have to apply static VAT values for billink,?
harli91
suggested changes
Mar 19, 2024
library/checkout/checkout.php
Outdated
Comment on lines
355
to
360
| $wrappingTaxRulesGroupId = (int)Configuration::get('PS_GIFT_WRAPPING_TAX_RULES_GROUP'); | ||
| // Get the VAT Rate for the Tax Rule Group | ||
| $address = new Address($this->cart->id_address_delivery); | ||
| $tax_manager = TaxManagerFactory::getManager($address, $wrappingTaxRulesGroupId); | ||
| $tax_calculator = $tax_manager->getTaxCalculator(); | ||
| $wrappingVatRate = $tax_calculator->getTotalRate(); |
There was a problem hiding this comment.
Not sure what these lines do, can you explain them to me? PS_GIFT_WRAPPING_TAX_RULES_GROUP by the name seems to be related to gift wrapping not products, not sure if this is correct
harli91
approved these changes
Mar 19, 2024
vegimcarkaxhija
deleted the
BP-3478-Payment-fee-is-not-working-for-BNPL-methods-Billink-Riverty-Klarna
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.