Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BP-3900 PayPal express transactions push timing issue #1109

Merged
merged 9 commits into from
Nov 27, 2024
Merged

BP-3900 PayPal express transactions push timing issue #1109

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5298565
BP-3900-PayPal Express transactions PUSH timing issue
SandervdHulst Nov 13, 2024
fd143c5
BP-3900-PayPal Express transactions PUSH timing issue
SandervdHulst Nov 13, 2024
54ba0ad
BP-3900-PayPal Express transactions PUSH timing issue
SandervdHulst Nov 13, 2024
c462c18
BP-3900-PayPal Express transactions PUSH timing issue
SandervdHulst Nov 13, 2024
c967c55
BP-3900-PayPal Express transactions PUSH timing issue
SandervdHulst Nov 13, 2024
b683a51
BP-3900-PayPal Express transactions PUSH timing issue
SandervdHulst Nov 13, 2024
f89939f
BP-3900-PayPal Express transactions PUSH timing issue
SandervdHulst Nov 13, 2024
f7d5919
BP-3900-PayPal Express transactions PUSH timing issue
SandervdHulst Nov 13, 2024
3073f6e
BP-3900-PayPal Express transactions PUSH timing issue
SandervdHulst Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions Model/Method/Paypal.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ class Paypal extends AbstractMethod
*/
protected $_code = self::PAYMENT_METHOD_CODE;

/**
* @param \Magento\Sales\Api\Data\OrderPaymentInterface|\Magento\Payment\Model\InfoInterface $payment
*
* @return bool|string
*/
public function getPaymentMethodName($payment)
{
return $this->buckarooPaymentMethodCode;
}

/**
* {@inheritdoc}
*/
Expand All @@ -59,9 +69,9 @@ public function getOrderTransactionBuilder($payment)
"Name" => "PayPalOrderId",
"_" => $expressOrderId
];
$payment->setAdditionalInformation('skip_push', 1);
}


/** @noinspection PhpUndefinedMethodInspection */
$transactionBuilder->setOrder($payment->getOrder())
->setServices($services)
Expand Down Expand Up @@ -93,14 +103,4 @@ public function getVoidTransactionBuilder($payment)
{
return true;
}

/**
* @param \Magento\Sales\Api\Data\OrderPaymentInterface|\Magento\Payment\Model\InfoInterface $payment
*
* @return bool|string
*/
public function getPaymentMethodName($payment)
{
return $this->buckarooPaymentMethodCode;
}
}
Loading