Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/clean up solution: warnings & .NET 4.8 #49

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

timvandenhof
Copy link

@timvandenhof timvandenhof commented Jul 22, 2021

  • Retarget test project to latest .NET Full Framework 4.8.
  • Fix warnings and code style messages.
  • Remove not available dependency references that are not used.
  • Added some XmlDoc.
  • Fixed a few files that have tabs and spaces mixed, causing issues in browsing source code on GitHub.
  • Breaking change: removed ResponseHandler.cs as it is obsolete for over 4 years now and not referenced.

Note: Was not able to run tests, see issue #48 .

…' can be converted to a method as its get accessor is never invoked.
…DataRequest' can be removed as the value assigned to it is never read
…can be removed as the value assigned to it is never read
…ion' can be removed as the value assigned to it is never read
…of a shipped public API ==> Marked obsolete, added new constructor
…t' can be converted to a method as its get accessor is never invoked.
…dInfo(TransactionRefundInfoBase)' is obsolete: 'Parameter transactionRefundInfoBase is no longer needed.'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant