BA-383 Fix issue when a built in PHP function name is sent in the payload #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShuCh3n
approved these changes
Jul 16, 2024
vildanbina
reviewed
Jul 16, 2024
| @@ -65,7 +65,7 @@ protected function appendParameter(?int $groupKey, ?string $groupType, string $n | |||
| { | |||
| if (! is_null($value)) | |||
| { | |||
| if (is_callable($value)) | |||
| if (method_exists($this, $value)) | |||
There was a problem hiding this comment.
we were checking if $value is a function, why is it like this now?
even if it returns true, further down you are executing $value itself, and not $this->{$value}
There was a problem hiding this comment.
Since, we couldn't find any case where this will be used, and there's nothing regarding this on docs I've removed the check. Tested the payments and everything seem to work fine.
There was a problem hiding this comment.
In the SDK, it seems that it has not been used, but this might have been used by a user, as I don't believe it was there without a reason
DjellzeBllaca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.