Bugs and code smells

README.md

@@ -56,7 +56,8 @@ You can find your credentials in plaza  [WEBSITE_KEY](https://plaza.buckaroo.nl/
 require __DIR__ . '/vendor/autoload.php';
 
 # Get your website & secret key in your plaza.
-# You can perform a test payment by giving the third param with the string "test", on default it is set on "live"
+# You can perform a test payment by giving the third param with the string "test", on default it is set on "test".
+# By changing the value of the third parameter to "live", a live transaction can be performed.
 $buckaroo = new \BuckarooClient('WEBSITE_KEY', 'SECRET_KEY', 'test');
 ```
 

example/additional_services/credit_management.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 use Buckaroo\Resources\Constants\Gender;
@@ -55,7 +55,8 @@
                 ],
             ]);
 
-// In this case, we have the payload stored in the $invoice variable. We can now combine it with the next payment using the combine method
+// In this case, we have the payload stored in the $invoice variable.
+// We can now combine it with the next payment using the combine method.
 
 $response = $buckaroo->method('sepadirectdebit')->combine($invoice)->pay([
     'invoice' => uniqid(),

example/additional_services/idin.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 

example/additional_services/marketplaces.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 

example/additional_services/pay_per_email.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 use Buckaroo\Resources\Constants\Gender;

example/additional_services/subscriptions.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 use Buckaroo\Resources\Constants\Gender;
@@ -70,7 +70,7 @@
         ],
     ],
     'phone' => [
-        'mobile' => '0612345678',
+        'mobile' => '0612345679',
     ],
     'debtor' => [
         'code' => 'johnsmith4',
@@ -113,7 +113,7 @@
         'country' => 'NL',
     ],
     'phone' => [
-        'mobile' => '0612345678',
+        'mobile' => '0612345670',
     ],
 ]);
 

example/additional_services/surepay.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 

example/additional_services/voucher.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 

example/additional_services/wallets.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 

example/bootstrap.php

@@ -1,5 +1,7 @@
 <?php
 
+namespace Example\Bootstrap;
+
 use Dotenv\Dotenv;
 
 require_once __DIR__ . "/../vendor/autoload.php";

example/responses/push.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 use Buckaroo\Handlers\Reply\ReplyHandler;
@@ -14,7 +14,8 @@
     "brq_customer_name" => "J. de Tèster",
     "brq_invoicenumber" => "SDKDevelopment.com_INVOICE_NO_628c6d032af90",
     "brq_ordernumber" => "SDKDevelopment.com_ORDER_NO_628c6d032af95",
-    "brq_payer_hash" => "2d26d34584a4eafeeaa97eed10cfdae22ae64cdce1649a80a55fafca8850e3e22cb32eb7c8fc95ef0c6f96669a21651d4734cc568816f9bd59c2092911e6c0da",
+    "brq_payer_hash" => "2d26d34584a4eafeeaa97eed10cfdae22ae64cdce1649a80a55fafca8850e3e22cb32eb7c8fc95ef0c6f96669a2
+    1651d4734cc568816f9bd59c2092911e6c0da",
     "brq_payment" => "D44ACDD0F99D4A1C811D2CD3EFDB05BA",
     "brq_payment_method" => "ideal",
     "brq_SERVICE_ideal_consumerBIC" => "RABONL2U",
@@ -40,7 +41,18 @@
 
 //START JSON PUSH
 $auth_header = 'IBjihN7Fhp:0YvyjYAzDQ28W+hQi80f2nhe0Z1QFJLbz7IH//6LsAU=:cad1832100784f57a6e6de835d9f3638:1658227572';
-$post_data = '{"Transaction":{"Key":"5340604668D74435AA344E1428ED1292","Invoice":"62d68b6c8ab0c","ServiceCode":"ideal","Status":{"Code":{"Code":190,"Description":"Success"},"SubCode":{"Code":"S001","Description":"Transaction successfully processed"},"DateTime":"2022-07-19T12:46:12"},"IsTest":true,"Order":"ORDER_NO_62d68b6ca2df3","Currency":"EUR","AmountDebit":10.1,"TransactionType":"C021","Services":[{"Name":"ideal","Action":null,"Parameters":[{"Name":"consumerIssuer","Value":"ABN AMRO"},{"Name":"transactionId","Value":"0000000000000001"},{"Name":"consumerName","Value":"J. de Tèster"},{"Name":"consumerIBAN","Value":"NL44RABO0123456789"},{"Name":"consumerBIC","Value":"RABONL2U"}],"VersionAsProperty":2}],"CustomParameters":null,"AdditionalParameters":{"List":[{"Name":"initiated_by_magento","Value":"1"},{"Name":"service_action","Value":"something"}]},"MutationType":1,"RelatedTransactions":null,"IsCancelable":false,"IssuingCountry":null,"StartRecurrent":false,"Recurring":false,"CustomerName":"J. de Tèster","PayerHash":"2d26d34584a4eafeeaa97eed10cfdae22ae64cdce1649a80a55fafca8850e3e22cb32eb7c8fc95ef0c6f96669a21651d4734cc568816f9bd59c2092911e6c0da","PaymentKey":"AEC974D455FF4A4B9B4C21E437A04838","Description":null}}';
+$post_data = '{"Transaction":{"Key":"5340604668D74435AA344E1428ED1292","Invoice":"62d68b6c8ab0c","ServiceCode":"ideal",
+"Status":{"Code":{"Code":190,"Description":"Success"},"SubCode":{"Code":"S001",
+"Description":"Transaction successfully processed"},"DateTime":"2022-07-19T12:46:12"},"IsTest":true,
+"Order":"ORDER_NO_62d68b6ca2df3","Currency":"EUR","AmountDebit":10.1,"TransactionType":"C021",
+"Services":[{"Name":"ideal","Action":null,"Parameters":[{"Name":"consumerIssuer","Value":"ABN AMRO"},
+{"Name":"transactionId","Value":"0000000000000001"},{"Name":"consumerName","Value":"J. de Tèster"},
+{"Name":"consumerIBAN","Value":"NL44RABO0123456789"},{"Name":"consumerBIC","Value":"RABONL2U"}],
+"VersionAsProperty":2}],"CustomParameters":null,"AdditionalParameters":{"List":[{"Name":"initiated_by_magento",
+"Value":"1"},{"Name":"service_action","Value":"something"}]},"MutationType":1,"RelatedTransactions":null,
+"IsCancelable":false,"IssuingCountry":null,"StartRecurrent":false,"Recurring":false,"CustomerName":"J. de Tèster",
+"PayerHash":"2d26d34584a4eafeeaa97eed10cfdae22ae64cdce1649a80a55fafca8850e3e22cb32eb7c8fc95ef0c6f96669a21651d4734
+cc568816f9bd59c2092911e6c0da","PaymentKey":"AEC974D455FF4A4B9B4C21E437A04838","Description":null}}';
 $uri = 'https://buckaroo.dev/push';
 
 $reply_handler = new ReplyHandler($buckaroo->client()->config(), $post_data, $auth_header, $uri);

example/responses/return.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 
@@ -10,7 +10,8 @@
     "brq_customer_name" => "J. de Tèster",
     "brq_invoicenumber" => "SDKDevelopment.com_INVOICE_NO_628c6d032af90",
     "brq_ordernumber" => "SDKDevelopment.com_ORDER_NO_628c6d032af95",
-    "brq_payer_hash" => "2d26d34584a4eafeeaa97eed10cfdae22ae64cdce1649a80a55fafca8850e3e22cb32eb7c8fc95ef0c6f96669a21651d4734cc568816f9bd59c2092911e6c0da",
+    "brq_payer_hash" => "2d26d34584a4eafeeaa97eed10cfdae22ae64cdce1649a80a55fafca8850e3e22cb32eb7c8fc95ef0c6f966
+    69a21651d4734cc568816f9bd59c2092911e6c0da",
     "brq_payment" => "D44ACDD0F99D4A1C811D2CD3EFDB05BA",
     "brq_payment_method" => "ideal",
     "brq_SERVICE_ideal_consumerBIC" => "RABONL2U",

example/transactions/afterpay.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 use Buckaroo\Resources\Constants\RecipientCategory;
@@ -35,7 +35,7 @@
         ],
         'phone' => [
             'mobile' => '0698765433',
-            'landline' => '0109876543',
+            'landline' => '0109876541',
         ],
         'email' => '[email protected]',
     ],
@@ -103,7 +103,7 @@
             'firstName' => 'Test',
             'lastName' => 'Acceptatie',
             'email' => '[email protected]',
-            'phone' => '0109876543',
+            'phone' => '0109876542',
             'street' => 'Hoofdstraat',
             'streetNumber' => '80',
             'streetNumberAdditional' => 'A',

example/transactions/afterpaydigiaccept.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 use Buckaroo\Resources\Constants\Gender;

example/transactions/alipay.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 

example/transactions/applepay.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 

example/transactions/applepay_redirect.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 

example/transactions/bancontact.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 
@@ -9,8 +9,10 @@
 //Also accepts json
 //Pay
 $response = $buckaroo->method('bancontactmrcash')->pay([
-    //'saveToken' => true, //SaveToken is the parameter used to indicate if a token is to be created, that can be used for Wallet Initiated Payments in the future.
-    //'encryptedCardData' => '', //If this is set PayEncryoted Action will be used. The value of this parameter is the result of the "encryptCardData"-function of our Client Side Encryption SDK.
+    //'saveToken' => true, //SaveToken is the parameter used to indicate if a token is to be created, that can be used
+    // for Wallet Initiated Payments in the future.
+    //'encryptedCardData' => '', //If this is set PayEncryoted Action will be used.
+    // The value of this parameter is the result of the "encryptCardData"-function of our Client Side Encryption SDK.
     'invoice' => uniqid(),
     'amountDebit' => 10.10,
 ]);
@@ -20,7 +22,10 @@
     'invoice' => uniqid(),
     'amountDebit' => 10.10,
     'description' => 'Bancontact PayEncrypted Test 123',
-    'encryptedCardData' => '001SlXfd8MbiTd/JFwCiGVs3f6o4x6xt0aN29NzOSNZHPKlVsz/EWeQmyhb1gGZ86VY88DP7gfDV+UyjcPfpVfHZd7u+WkO71hnV2QfYILCBNqE1aiPv2GQVGdaGbuoQloKu1o3o3I1UDmVxivXTMQX76ovot89geA6hqbtakmpmvxeiwwea3l4htNoX1IlD1hfYkDDl9rzSu5ypcjvVs6aRGXK5iMHnyrmEsEnfdj/Q5XWbsD5xAm4u3y6J8d4UP7LB31VLECzZUTiJOtKKcCQlT01YThIkQlj8PWBBMtt4H52VN3IH2+wPYtR8HiOZzcA2HA7UxozogIpS53tIURj/g==',
+    'encryptedCardData' => '001SlXfd8MbiTd/JFwCiGVs3f6o4x6xt0aN29NzOSNZHPKlVsz/EWeQmyhb1gGZ86VY88DP7gfDV+UyjcP
+    fpVfHZd7u+WkO71hnV2QfYILCBNqE1aiPv2GQVGdaGbuoQloKu1o3o3I1UDmVxivXTMQX76ovot89geA6hqbtakmpmvxeiwwea3l4htNoX
+    1IlD1hfYkDDl9rzSu5ypcjvVs6aRGXK5iMHnyrmEsEnfdj/Q5XWbsD5xAm4u3y6J8d4UP7LB31VLECzZUTiJOtKKcCQlT01YThIkQlj8PW
+    BBMtt4H52VN3IH2+wPYtR8HiOZzcA2HA7UxozogIpS53tIURj/g==',
 ]);
 
 //Recurrent payment

example/transactions/belfius.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 

example/transactions/billink.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 
@@ -176,7 +176,8 @@
 
 //Cancel authorize
 $response = $buckaroo->method('billink')->cancelAuthorize([
-    'originalTransactionKey' => '74AD098CCFAA4F739FE16279B5059B6B', //Set transaction key of the authorized transaction to cancel
+    'originalTransactionKey' => '74AD098CCFAA4F739FE16279B5059B6B',
+    //Set transaction key of the authorized transaction to cancel
     'invoice' => '62905fa2650f4', //Set invoice id
     'AmountCredit' => 10, //set amount to capture
 ]);

example/transactions/credit_click.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 

example/transactions/creditcard.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 
@@ -18,7 +18,8 @@
     'amountDebit' => 10,
     'invoice' => uniqid(),
     'name' => 'mastercard',
-    'cardData' => '001u8gJNwngKubFCO6FmJod6aESlIFATkKYaj47KlgBp7f3NeVxUzChg1Aug7WD2vc5wut2KU9NPLUaO0tFmzhVLZoDWn7dX4AzGxSjPrsPmDMWYcEkIwMZfcyJqoRfFkF3j15mil3muXxhR1a609NfkTo11J3ENVsvU3k60z',
+    'cardData' => '001u8gJNwngKubFCO6FmJod6aESlIFATkKYaj47KlgBp7f3NeVxUzChg1Aug7WD2vc5wut2KU9NPLUaO0tFmzhVLZoDW
+    n7dX4AzGxSjPrsPmDMWYcEkIwMZfcyJqoRfFkF3j15mil3muXxhR1a609NfkTo11J3ENVsvU3k60z',
 ]);
 
 //Pay with security code
@@ -27,7 +28,8 @@
     'invoice' => uniqid(),
     'originalTransactionKey' => '6C5DBB69E74644958F8C25199514DC6C',
     'name' => 'mastercard',
-    'securityCode' => '001u8gJNwngKubFCO6FmJod6aESlIFATkKYaj47KlgBp7f3NeVxUzChg1Aug7WD2vc5wut2KU9NPLUaO0tFmzhVLZoDWn7dX4AzGxSjPrsPmDMWYcEkIwMZfcyJqoRfFkF3j15mil3muXxhR1a609NfkTo11J3ENVsvU3k60z',
+    'securityCode' => '001u8gJNwngKubFCO6FmJod6aESlIFATkKYaj47KlgBp7f3NeVxUzChg1Aug7WD2vc5wut2KU9NPLUaO0tFmzhVLZoDW
+    n7dX4AzGxSjPrsPmDMWYcEkIwMZfcyJqoRfFkF3j15mil3muXxhR1a609NfkTo11J3ENVsvU3k60z',
 ]);
 
 //Refund
@@ -50,7 +52,8 @@
     'amountDebit' => 10,
     'invoice' => uniqid(),
     'name' => 'mastercard',
-    'cardData' => '001u8gJNwngKubFCO6FmJod6aESlIFATkKYaj47KlgBp7f3NeVxUzChg1Aug7WD2vc5wut2KU9NPLUaO0tFmzhVLZoDWn7dX4AzGxSjPrsPmDMWYcEkIwMZfcyJqoRfFkF3j15mil3muXxhR1a609NfkTo11J3ENVsvU3k60z',
+    'cardData' => '001u8gJNwngKubFCO6FmJod6aESlIFATkKYaj47KlgBp7f3NeVxUzChg1Aug7WD2vc5wut2KU9NPLUaO0tFmzhVLZoDW
+    n7dX4AzGxSjPrsPmDMWYcEkIwMZfcyJqoRfFkF3j15mil3muXxhR1a609NfkTo11J3ENVsvU3k60z',
 ]);
 
 //Authorize with security code
@@ -59,7 +62,8 @@
     'invoice' => uniqid(),
     'originalTransactionKey' => '6C5DBB69E74644958F8C25199514DC6C',
     'name' => 'mastercard',
-    'securityCode' => '001u8gJNwngKubFCO6FmJod6aESlIFATkKYaj47KlgBp7f3NeVxUzChg1Aug7WD2vc5wut2KU9NPLUaO0tFmzhVLZoDWn7dX4AzGxSjPrsPmDMWYcEkIwMZfcyJqoRfFkF3j15mil3muXxhR1a609NfkTo11J3ENVsvU3k60z',
+    'securityCode' => '001u8gJNwngKubFCO6FmJod6aESlIFATkKYaj47KlgBp7f3NeVxUzChg1Aug7WD2vc5wut2KU9NPLUaO0tFmzhVLZoDW
+    n7dX4AzGxSjPrsPmDMWYcEkIwMZfcyJqoRfFkF3j15mil3muXxhR1a609NfkTo11J3ENVsvU3k60z',
 ]);
 
 //Capture
@@ -68,7 +72,8 @@
     'invoice' => uniqid(),
     'originalTransactionKey' => '6C5DBB69E74644958F8C25199514DC6C',
     'name' => 'mastercard',
-    'securityCode' => '001u8gJNwngKubFCO6FmJod6aESlIFATkKYaj47KlgBp7f3NeVxUzChg1Aug7WD2vc5wut2KU9NPLUaO0tFmzhVLZoDWn7dX4AzGxSjPrsPmDMWYcEkIwMZfcyJqoRfFkF3j15mil3muXxhR1a609NfkTo11J3ENVsvU3k60z',
+    'securityCode' => '001u8gJNwngKubFCO6FmJod6aESlIFATkKYaj47KlgBp7f3NeVxUzChg1Aug7WD2vc5wut2KU9NPLUaO0tFmzhVLZoDW
+    n7dX4AzGxSjPrsPmDMWYcEkIwMZfcyJqoRfFkF3j15mil3muXxhR1a609NfkTo11J3ENVsvU3k60z',
 ]);
 
 //Pay Recurrent
@@ -77,5 +82,6 @@
     'invoice' => uniqid(),
     'originalTransactionKey' => '6C5DBB69E74644958F8C25199514DC6C',
     'name' => 'mastercard',
-    'securityCode' => '001u8gJNwngKubFCO6FmJod6aESlIFATkKYaj47KlgBp7f3NeVxUzChg1Aug7WD2vc5wut2KU9NPLUaO0tFmzhVLZoDWn7dX4AzGxSjPrsPmDMWYcEkIwMZfcyJqoRfFkF3j15mil3muXxhR1a609NfkTo11J3ENVsvU3k60z',
+    'securityCode' => '001u8gJNwngKubFCO6FmJod6aESlIFATkKYaj47KlgBp7f3NeVxUzChg1Aug7WD2vc5wut2KU9NPLUaO0tFmzhVLZoDW
+    n7dX4AzGxSjPrsPmDMWYcEkIwMZfcyJqoRfFkF3j15mil3muXxhR1a609NfkTo11J3ENVsvU3k60z',
 ]);

example/transactions/eps.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 

example/transactions/giftcards.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 

example/transactions/giftcards_redirect.php

@@ -1,6 +1,6 @@
 <?php
 
-require('../bootstrap.php');
+require_once '../bootstrap.php';
 
 use Buckaroo\BuckarooClient;
 
@@ -11,7 +11,10 @@
 $response = $buckaroo->method('giftcard')->payRedirect([
     'amountDebit' => 10,
     'invoice' => uniqid(),
-    'servicesSelectableByClient' => 'westlandbon,ideal,babygiftcard,babyparkgiftcard,beautywellness,boekenbon,boekenvoordeel,designshopsgiftcard,fashioncheque,fashionucadeaukaart,fijncadeau,koffiecadeau,kokenzo,kookcadeau,nationaleentertainmentcard,naturesgift,podiumcadeaukaart,shoesaccessories,webshopgiftcard,wijncadeau,wonenzo,yourgift,vvvgiftcard,parfumcadeaukaart',
+    'servicesSelectableByClient' => 'westlandbon,ideal,babygiftcard,babyparkgiftcard,beautywellness,boekenbon,
+    boekenvoordeel,designshopsgiftcard,fashioncheque,fashionucadeaukaart,fijncadeau,koffiecadeau,kokenzo,
+    kookcadeau,nationaleentertainmentcard,naturesgift,podiumcadeaukaart,shoesaccessories,webshopgiftcard,
+    wijncadeau,wonenzo,yourgift,vvvgiftcard,parfumcadeaukaart',
     'continueOnIncomplete' => '1',
 ]);