Expand tests and test sharp #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jdub233
commented
Feb 7, 2024
jdub233
commented
- Simplifies the reference to the bucket name to make it easier to control for unit testing
- Adds a mocked S3 response consisting of a valid one-pixel JPEG image
- Runs the simulated image through the sharp library to confirm that it can scale the image
- Expands on the existing tests
Declaring the variable as a const outside of the function scope makes it more difficult to run unit tests. Using it directly makes it easier for unit tests to control the value.
and run it through the tests, engaging the sharp library to make sure it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.