-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding compiling instructions #203
Open
Shideravan
wants to merge
7
commits into
bsnes-emu:master
Choose a base branch
from
Shideravan:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may help newcomers on how to easily compile bsnes
jchv
reviewed
Aug 5, 2021
Looks OK overall. I think that it would be worth considering Msys2 as a recommended path forward, though, as it is probably the most complete MinGW distribution that is well-maintained. |
Sorry it's taken me a while to look at this. I have some small and large concerns:
|
Ok, I'll take all that in consideration and will rewrite the text as soon as I can |
* MSYS is being recomended as another good alternative (thanks for the suggestion @jchv * bsnes isn't bold anymore * I changed back the link in comunity section for the same invite link already it has (and now with a fancy new button) * Changed the I and II to more usual markdown items * Now all the text in the README is using default MD (then rather than "-----" we have hyrarchical subtitling * The prerequisites now is separated and better explained. Note that I'm just pointing the websites for the user get his better suited version of the compilation suite * Git is now optional. Further instructions is given about how to download the code manually without the need of Git. * Now the text is no longer "windows only" with instructions that can be used in Linux and MacOS too.
It's linked with the bsnes license page
Thanks for the feedback @Screwtapello and @jchv |
Shideravan
changed the title
Adding windows compile instructions
Adding compiling instructions
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may help newcomers on how to easily compile bsnes