Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building universal binaries on macOS. #150

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jchv
Copy link
Contributor

@jchv jchv commented Feb 11, 2021

I've attempted to compartmentalize the added complexity as much as possible. It could be improved also if we could make hiro and ruby use the nall compile function.

I'm going to let this rip on CI to see if it works.

Fixes #149.

@Screwtapello
Copy link
Contributor

It seems GitHub Actions does not have a modern-enough macOS toolchain for this, yet: actions/runner-images#2486

It would be nice to teach nall's $(compile) function to accept the extra flags that hiro and ruby need, instead of those libraries defining their own version.

I also wonder if the "universal binary" flag option should be local=false, since "only compile for my CPU architecture" is basically the same idea as "only compile for my CPU microarchitecture" but moreso.

@seeseekey
Copy link

Is there a description how i can compile these branch on macOS (M1) - cd bsnes / make?

@jchv
Copy link
Contributor Author

jchv commented Feb 23, 2021

@seeseekey

Is there a description how i can compile these branch on macOS (M1) - cd bsnes / make?

Try this.

cd path/to/the/cloned/repo
make -j8 -C bsnes local=false

It should work if you have XCode installed. Then there should be a copy of bsnes in bsnes/out/bsnes.app.

I did also provide an M1 build over at #148 (comment) in case you missed it.

@seeseekey
Copy link

seeseekey commented Feb 24, 2021

Thank you; it works :)

I have seen the build, but it doesn't run on my M1 Mac, so I tried to compile it by myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support compiling universal macOS binaries.
3 participants