-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/consensus/ restart #507
Draft
Mododo
wants to merge
9
commits into
master
Choose a base branch
from
fix/consensus/reproducible-restart
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,458
−1,416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
==========================================
- Coverage 44.21% 43.74% -0.48%
==========================================
Files 269 270 +1
Lines 47585 48296 +711
Branches 47585 48296 +711
==========================================
+ Hits 21041 21127 +86
- Misses 25461 26084 +623
- Partials 1083 1085 +2 ☔ View full report in Codecov by Sentry. |
Mododo
force-pushed
the
fix/consensus/reproducible-restart
branch
2 times, most recently
from
December 26, 2024 21:39
d2ab1a8
to
9d337a0
Compare
logs and owned `Bytes` for later
restart with empty DB will be done the other way
fix: leader did not produce point at restart
fixes potential race when point is accounted in threshold but not yet resolved in DAG
fixes potential lock contention
* remove potential mutual `.await` of cloned futures in equivocation check * FIXME: sign or reject location when point can no longer be referenced
fixes sign or reject issue from previous commit
* split download and restore futures * do not produce alternative point if db was removed
Mododo
force-pushed
the
fix/consensus/reproducible-restart
branch
from
December 27, 2024 13:56
9d337a0
to
8471d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.