Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): download shard blocks in archive provider #487

Merged
merged 7 commits into from
Dec 10, 2024

Conversation

Rexagon
Copy link
Member

@Rexagon Rexagon commented Dec 4, 2024

No description provided.

@Rexagon Rexagon force-pushed the feat/download-shard-blocks branch from 6e918ef to 8ca18b7 Compare December 4, 2024 18:27
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 29.69543% with 277 lines in your changes missing coverage. Please review.

Project coverage is 43.85%. Comparing base (3cb9be6) to head (a75211a).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...ore/src/block_strider/provider/archive_provider.rs 0.00% 188 Missing ⚠️
core/src/block_strider/provider/mod.rs 62.06% 32 Missing and 1 partial ⚠️
.../src/block_strider/provider/blockchain_provider.rs 3.22% 30 Missing ⚠️
block-util/src/archive/mod.rs 0.00% 12 Missing ⚠️
cli/src/node/mod.rs 0.00% 6 Missing ⚠️
...ore/src/block_strider/provider/storage_provider.rs 55.55% 4 Missing ⚠️
core/src/block_strider/mod.rs 86.66% 0 Missing and 2 partials ⚠️
core/src/block_strider/provider/box_provider.rs 93.75% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
+ Coverage   43.83%   43.85%   +0.01%     
==========================================
  Files         269      269              
  Lines       47294    47404     +110     
  Branches    47294    47404     +110     
==========================================
+ Hits        20733    20787      +54     
- Misses      25498    25555      +57     
+ Partials     1063     1062       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rexagon Rexagon force-pushed the feat/download-shard-blocks branch 3 times, most recently from 0a8cd99 to b883c85 Compare December 10, 2024 19:00
@Rexagon Rexagon marked this pull request as ready for review December 10, 2024 19:01
@Rexagon Rexagon force-pushed the feat/download-shard-blocks branch from b883c85 to a05beb8 Compare December 10, 2024 19:25
@Rexagon Rexagon enabled auto-merge December 10, 2024 21:36
@Rexagon Rexagon linked an issue Dec 10, 2024 that may be closed by this pull request
2 tasks
@Rexagon Rexagon force-pushed the feat/download-shard-blocks branch from e52c214 to a75211a Compare December 10, 2024 22:21
@Rexagon Rexagon added this pull request to the merge queue Dec 10, 2024
Merged via the queue into master with commit 90a77a1 Dec 10, 2024
8 of 9 checks passed
@Rexagon Rexagon deleted the feat/download-shard-blocks branch December 10, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve get_next_block reliability
3 participants