Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format all models for consistency #390

Merged
merged 10 commits into from
Aug 30, 2024
Merged

Format all models for consistency #390

merged 10 commits into from
Aug 30, 2024

Conversation

poloaraujo
Copy link
Member

@poloaraujo poloaraujo commented Oct 2, 2023 •
edited
Loading

Overview

Currently there are inconsistencies in the SQL scripts styles used (e.g. trailing vs leading commas). I've formatted al sources, staging models, fact models and core models (both dimensional and fact) to have a consistent format for both spacing and commas (of which all use trailing)

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

Issue #383

Outstanding questions

So far, I've only tested locally with Snowflake

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests October 2, 2023 18:09 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests October 2, 2023 18:09 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests October 2, 2023 18:09 — with GitHub Actions Inactive
@poloaraujo poloaraujo had a problem deploying to Approve Integration Tests October 2, 2023 18:09 — with GitHub Actions Failure
glsdown
glsdown approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@glsdown glsdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending approval from our robot overlords (i.e. the CI Linter) this looks great to me! Thank you for doing this. 🎉

@poloaraujo
SQL Fluff changes
bf46483 
- Removed L02 from tox.ini
- Formatted dim_dbt__current_models
@poloaraujo poloaraujo had a problem deploying to Approve Integration Tests October 4, 2023 17:31 — with GitHub Actions Failure
@poloaraujo poloaraujo had a problem deploying to Approve Integration Tests October 4, 2023 17:31 — with GitHub Actions Failure
@poloaraujo poloaraujo had a problem deploying to Approve Integration Tests October 4, 2023 17:31 — with GitHub Actions Failure
@poloaraujo poloaraujo had a problem deploying to Approve Integration Tests October 4, 2023 17:31 — with GitHub Actions Failure
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:43 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:43 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:43 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:43 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:46 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:46 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:46 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:46 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:46 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:46 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:46 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:46 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:46 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:46 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:47 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 21, 2024 22:47 — with GitHub Actions Inactive
llifoawing
llifoawing requested changes Aug 22, 2024
View reviewed changes
Copy link
Member

@llifoawing llifoawing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @poloaraujo - resurrecting this PR so we can merge your changes!

  • SQLfluff failed due to 3 single select targets being on new lines.
  • I was running into errors when running tox locally related to this issue - can you upgrade sqlfluff-templater-dbt~=3.0.7

models/dim_dbt__current_models.sql Outdated Show resolved Hide resolved
models/dim_dbt__current_models.sql Outdated Show resolved Hide resolved
models/dim_dbt__current_models.sql Outdated Show resolved Hide resolved
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:21 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:21 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:21 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:21 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests August 30, 2024 18:29 — with GitHub Actions Inactive
@poloaraujo poloaraujo merged commit c350293 into brooklyn-data:main Aug 30, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llifoawing llifoawing llifoawing approved these changes

@glsdown glsdown glsdown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poloaraujo @glsdown @llifoawing