Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix linting action #383

Open
glsdown opened this issue Sep 18, 2023 · 1 comment
Open

[Bug]: Fix linting action #383

glsdown opened this issue Sep 18, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@glsdown
Copy link
Contributor

glsdown commented Sep 18, 2023

Overview

Currently there are inconsistencies in the SQL scripts styles used (e.g. trailing vs leading commas). It's unclear if this is because the check was ignored when the files were amended, or if the check isn't working.

How to reproduce

  • Example leading commas - models/dim_dbt__current_models.sql
  • Example trailing commas - models/staging/stg_dbt__models.sql

Expected behaviour

All files to have consistent formatting.

Screenshots

Environment

Results of running dbt --version:

# Add the results here

Please paste the contents of your packages.yml file here:

packages:
  ...
@glsdown glsdown added the bug Something isn't working label Sep 18, 2023
@poloaraujo
Copy link
Member

I can see the inconsistencies. I propose a giant PR that switches everything to leading commas. I'd be up for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants