Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAWB-3840: add test to check reader can see published dataset #1490

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ahaessly
Copy link
Contributor

@ahaessly ahaessly commented Jan 3, 2019

This test won't pass until the new code is merged to dev.

  • Submitter: Include the JIRA issue number in the PR description
  • Submitter: Check documentation and code comments. Add explanatory PR comments if helpful.
  • Submitter: If you changed a URL that is used elsewhere (e.g. in an email), comment about where it is used and ensure the dependent code is updated.
  • Submitter: JIRA ticket checks:
    • Acceptance criteria exists and is met
    • Note any changes to implementation from the description
    • To Demo flag is set
    • Release Summary is filled out, if applicable
    • Add notes on how to QA
  • Submitter: Update RC_XXX release ticket with any config or environment changes necessary
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Submitter: If you're adding new libraries, sign us up to security updates for them
  • Submitter: If you're adding new automated UI tests, review the test plan with QA
  • Review cycle:
    • LR reviews
    • Rest of team may comment on PR at will
    • LR assigns to submitter for feedback fixes
    • Submitter rebases to develop again if necessary
    • Submitter makes further commits. DO NOT SQUASH
    • Submitter updates documentation as needed
    • Submitter reassigns to LR for further feedback
  • TL sign off
  • LR sign off
  • Product Owner sign off
  • Submitter: Verify all tests go green, including CI tests and automated UI tests.
  • Submitter: Squash commits and merge to develop. If adding test code, merge application code and test code at the same time.
  • Submitter: Delete branch after merge
  • Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
  • Submitter: Mark JIRA issue as resolved once this checklist is completed

Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Holding off on a thumb until it passes in Jenkins (which I realize is dependent on merging the other PR). Maybe just copy this test into the other PR?

  2. if/when the all_broad_users is magically kept updated, is it possible that this test will start failing because wsReaderUser is suddenly in that group? You could use demo_users for this test, or even some arbitrary UUID string.

@aweng98
Copy link
Contributor

aweng98 commented Jan 13, 2019

jenkins retest

1 similar comment
@ahaessly
Copy link
Contributor Author

jenkins retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants