-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to use class modal for configurations #536
base: main
Are you sure you want to change the base?
Conversation
At a glance this looks pretty good, but it's a big change so I will have to take some time to test everything and make sure it's working as expected. |
First thing I noticed is the config output is missing for these values (old output is shown below): Everything else appears to be o.k., but I want to test a bit more with live data. The relevant code is here: thetagang/thetagang/thetagang.py Lines 228 to 253 in 42b2cd2
|
I did some more testing, and overall it looks good and seems to not have broken anything. I think we can merge this once the missing config output is added back. |
No description provided.