fix: improve multi-save hot-reload time #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aralroca
changed the title
aralroca
changed the title
brisa-adapter-vercel
brisa-pandacss
brisa
brisa-tailwindcss
www
create-brisa
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #640
This PR improves the time when saving many times in a row during hot-reload.
Before:
A semaphore flag was waiting for the previous process to finish before starting the new one. This might make sense when we improve it so that instead of recompiling the whole app, it is done only for the specific file. Now, it does not make sense.
Now:
When a new process enters, it kills the previous one.