Rename: NullsView to BoolView #5496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnibs
force-pushed
the
vam-bool-view
branch
2 times, most recently
from
8bb2159
to
1ed5be8
Compare
mattnibs
commented
Nov 22, 2024
| @@ -71,7 +71,6 @@ func genFunc(name, op, typ string, lhs, rhs vector.Form) string { | |||
| s := fmt.Sprintf("func %s(lhs, rhs vector.Any) vector.Any {\n", name) | |||
| s += genVarInit("l", typ, lhs) | |||
| s += genVarInit("r", typ, rhs) | |||
| s += "nulls := vector.Or(l.Nulls, r.Nulls)\n" | |||
There was a problem hiding this comment.
This was incorrect when getting nulls of a view.
mattnibs
force-pushed
the
vam-bool-view
branch
2 times, most recently
from
6d9344f
to
8f796b0
Compare
nwt
approved these changes
Nov 22, 2024
Rename NullsView to BoolView since this can be used for creating views of Bool vectors as well. In addition have all an false value views of a boolean vector return a non-nil vector. When dealing with boolean values there's a difference between a false values and a nil vector. Also have NewView of a boolean vector create a new boolean vector.
mattnibs
force-pushed
the
vam-bool-view
branch
from
8f796b0
to
7247c64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename NullsView to BoolView since this can be used for creating views of Bool vectors as well. In addition have all an false value views of a boolean vector return a non-nil vector. When dealing with boolean values there's a difference between a false values and a nil vector.
Also have NewView of a boolean vector create a new boolean vector.