add SQL syntactic sugar to SPQ pipe operators #5479
Conversation
This commit adds some syntactic sugar so that UNNEST can be used in place of OVER, ORDER BY in place of SORT, and LIMIT in place of HEAD. We also unified the PEG grammar for the sort operaetor with the existing rules for SQL ORDER BY, and we added syntactic sugar for IS NULL and IS NOT NULL.
|
|
||
| IsNull | ||
| = IS _ NULL { return "==", nil } | ||
| / IS _ NOT _ NULL { return "!=", nil } | ||
|
|
There was a problem hiding this comment.
Should this be its own expression? Once we get to SQL semantics for null values IS NULL will behave differently than foo == null...
There was a problem hiding this comment.
Just getting the syntax in. When we change the null semantics, we can update this.
| data: | | ||
| FROM in.jsup | ||
| | UNNEST [...assignees,assignee] | ||
| | WHERE this IS NOT NULL |
There was a problem hiding this comment.
This doesn't feel right since currently FROM in.jsup | UNNEST [...assignees,assignee] evaluates to:
{login:"joe"}
{login:"fred"}
error("missing")
{login:"sue"}
{login:"joe"}
{login:"sue"}
error("missing")
or is error("missing") equivalent to null for this IS NOT NULL?
There was a problem hiding this comment.
Per the PartiQL paper
As far as the boolean connectives and IS NULL are concerned a NULL input and a MISSING input behave
identically.
Is this what you are going for here? If so comment withdrawn.
There was a problem hiding this comment.
This came from a SQL query where there is no MISSING or error("missing") and the behavior works with our current this!=null semantics and is also consistent with SQL++ semantics, so I think we're ok.
compiler/ztests/sql/assignees.yaml
Outdated
| @@ -0,0 +1,26 @@ | |||
|
|
|||
This commit adds some syntactic sugar so that UNNEST can be used in place of OVER, ORDER BY in place of SORT, and LIMIT in place of HEAD. We also unified the PEG grammar for the sort operaetor with the existing rules for SQL ORDER BY, and we added syntactic sugar for IS NULL and IS NOT NULL.