-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vam: Array Expressions #5462
vam: Array Expressions #5462
Conversation
3887792
to
15d571a
Compare
15d571a
to
e69d3fd
Compare
I happened to be revisiting the mgbench queries and since I get
Not sure if that's expected to work here or would come later, but figured I'd report. |
@philrz no support for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also change sequential array spreads so that spreads on non-array values yield the value itself.
What about docs? And record spreads on non-record values?
@nwt can we handle records in a separate pr? |
Given there's some controversy over this I'm just going to get rid of spread on primitives for now |
0b87a0b
to
595e351
Compare
cf0faf8
to
1a6e89d
Compare
@nwt ready for another review I added back the behavior where non-spreadable elements are ignored. |
2ab9b9d
to
6b3a206
Compare
4ba0f49
to
58d5444
Compare
58d5444
to
a8388b2
Compare
Add vector array expressions. When building an array in vector land you are often creating a non-union inner type that includes values from multiple vectors. This presents a problem because you cannot merge the vectors using a dynamic because dynamics are supposed to bubble up on be on top. As such I've added vector.Builder that is used to rebuild the multiple vectors to a single vector when this is encountered.