Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework precedence in expression operators #5424

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

mccanne
Copy link
Collaborator

@mccanne mccanne commented Nov 2, 2024

This commit reworks the precedence rules in the PEG grammar to follow the SQL rules.

@mccanne mccanne requested a review from a team November 2, 2024 20:17
Base automatically changed from select-from-parent to main November 3, 2024 16:25
This commit reworks the precedence rules in the PEG grammar to
follow the SQL rules.
@mccanne mccanne merged commit a985431 into main Nov 3, 2024
3 checks passed
@mccanne mccanne deleted the precedence-cherry branch November 3, 2024 17:03
@philrz
Copy link
Contributor

philrz commented Nov 3, 2024

Verified in super commit a985431.

With input data.csv:

CustomerID,Country
1,Germany
8,Spain

Before:

$ super -version
Version: v1.18.0-106-g7b6b9550

$ super -c "SELECT * FROM 'data.csv' WHERE NOT Country = 'Spain';"
[no output]

Now:

$ super -version
Version: v1.18.0-107-ga9854314

$ super -c "SELECT * FROM 'data.csv' WHERE NOT Country = 'Spain';"
{CustomerID:1.,Country:"Germany"}

Thanks @mccanne!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants