lakeapi: Use pool name/reference over pool id #4809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the lakeapi to use the pool name (which call also be the string version of the pool ID) over requiring the pool id when operating on a given pool. Apart from reducing the amount of requests needed when operating on a remote lake, this also allows for users to create a pool with ksuid name with Zed knowing how to resolve this correctly. Closes #4431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the lakeapi to use the pool name (which call also be the string version of the pool ID) over requiring the pool id when operating on a given pool. Apart from reducing the amount of requests needed when operating on a remote lake, this also allows for users to create a pool with ksuid name with Zed knowing how to resolve this correctly.
Closes #4431