Move dag.Assignment to compiler/dag/op.go (#5480)

It doesn't implement dag.Expr and grouping it with types that do is misleading.
brimdata · Nov 21, 2024 · 98f94ff · 98f94ff
1 parent c06e81a
commit 98f94ff
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/compiler/dag/expr.go b/compiler/dag/expr.go
@@ -27,11 +27,6 @@ type (
 		Kind  string       `json:"kind" unpack:""`
 		Elems []VectorElem `json:"elems"`
 	}
-	Assignment struct {
-		Kind string `json:"kind" unpack:""`
-		LHS  Expr   `json:"lhs"`
-		RHS  Expr   `json:"rhs"`
-	}
 	// A BadExpr node is a placeholder for an expression containing semantic
 	// errors.
 	BadExpr struct {

diff --git a/compiler/dag/op.go b/compiler/dag/op.go
@@ -294,6 +294,11 @@ func (*Deleter) OpNode() {}
 // Various Op fields
 
 type (
+	Assignment struct {
+		Kind string `json:"kind" unpack:""`
+		LHS  Expr   `json:"lhs"`
+		RHS  Expr   `json:"rhs"`
+	}
 	Case struct {
 		Expr Expr `json:"expr"`
 		Path Seq  `json:"seq"`