Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qd 9966 with bug #35

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/qodana.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,18 @@ jobs:
- run: echo ${{ github.event.pull_request.head.sha }}
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }} # to check out the actual pull request commit, not the merge commit
# ref: ${{ github.event.pull_request.head.sha }} # to check out the actual pull request commit, not the merge commit
fetch-depth: 0 # a full history is required for pull request analysis
- uses: actions/setup-node@v2
with:
node-version: '16'
- run: npm install
- run: npm run js-test-karma
- name: 'Qodana Scan'
uses: JetBrains/qodana-action@main
uses: JetBrains/qodana-action@v2024.2
env:
QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}
with:
use-nightly: true
upload-result: true


2 changes: 1 addition & 1 deletion js/src/carousel.js
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@
if (this._config.pause !== 'hover') {
return
}

// TODO: FOOBAR

Check warning on line 231 in js/src/carousel.js

View workflow job for this annotation

GitHub Actions / Qodana for JS

ESLint

ESLint: Unexpected 'todo' comment: 'TODO: FOOBAR'. (no-warning-comments)

Check warning on line 231 in js/src/carousel.js

View workflow job for this annotation

GitHub Actions / Qodana for JS

ESLint

ESLint: Unexpected 'todo' comment: 'TODO: FOOBAR'. (no-warning-comments)
// If it's a touch-enabled device, mouseenter/leave are fired as
// part of the mouse compatibility events on first tap - the carousel
// would stop cycling until user tapped out of it;
Expand Down
Loading